Log result in Tsumino and minor code cleanup

app/src/main/java/eu/kanade/tachiyomi/source/online/english/Tsumino.kt

@@ -2,6 +2,7 @@ package eu.kanade.tachiyomi.source.online.english
 
 import android.content.Context
 import android.net.Uri
+import com.crashlytics.android.Crashlytics
 import com.github.salomonbrys.kotson.*
 import com.google.gson.JsonParser
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
@@ -13,6 +14,7 @@ import eu.kanade.tachiyomi.source.model.*
 import eu.kanade.tachiyomi.source.online.LewdSource
 import eu.kanade.tachiyomi.source.online.ParsedHttpSource
 import eu.kanade.tachiyomi.util.asJsoup
+import eu.kanade.tachiyomi.util.toast
 import exh.TSUMINO_SOURCE_ID
 import exh.ui.captcha.CaptchaCompletionVerifier
 import exh.ui.captcha.SolveCaptchaActivity
@@ -316,9 +318,10 @@ class Tsumino(private val context: Context): ParsedHttpSource(), LewdSource<Tsum
                 Page(index, chapter.url + "#${index + 1}", newImageUrl.toString())
             }
         }.doOnError {
+            try {
                 val aspNetCookie = preferences.eh_ts_aspNetCookie().getOrDefault()
 
-                    val cookiesMap = if(aspNetCookie.isNotBlank())
+                val cookiesMap = if (aspNetCookie.isNotBlank())
                     mapOf(ASP_NET_COOKIE_NAME to aspNetCookie)
                 else
                     emptyMap()
@@ -328,6 +331,10 @@ class Tsumino(private val context: Context): ParsedHttpSource(), LewdSource<Tsum
                         cookiesMap,
                         CAPTCHA_SCRIPT,
                         "$BASE_URL/Read/Auth/$id")
+            } catch(t: Throwable) {
+                Crashlytics.logException(t)
+                context.toast("Could not launch captcha-solving activity: ${t.message}")
+            }
         }
     }
 

app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryCategoryAdapter.kt

@@ -67,9 +67,9 @@ class LibraryCategoryAdapter(val view: LibraryCategoryView) :
             }
 
             try {
-                val thisCache = globalSearchCache.getOrPut(view.category.name, {
+                val thisCache = globalSearchCache.getOrPut(view.category.name) {
                     SearchCache(mangas.size)
-                })
+                }
 
                 if(thisCache.ready) {
                     //Skip everything if cache matches our query exactly

app/src/main/java/exh/metadata/MetadataHelper.kt

@@ -31,20 +31,20 @@ fun Realm.queryMetadataFromManga(manga: Manga,
 fun Realm.syncMangaIds(mangas: List<LibraryItem>) {
     Timber.d("--> EH: Begin syncing ${mangas.size} manga IDs...")
     executeTransaction {
-        mangas.filter {
+        mangas.forEach { manga ->
-            isLewdSource(it.manga.source)
+            if(isLewdSource(manga.manga.source)) {
-        }.forEach { manga ->
                 try {
                     manga.hasMetadata =
                             queryMetadataFromManga(manga.manga).findFirst()?.let { meta ->
                                 meta.mangaId = manga.manga.id
                                 true
                             } ?: false
-            } catch(e: Exception) {
+                } catch (e: Exception) {
                     Timber.w(e, "Error syncing manga IDs! Ignoring...")
                 }
             }
         }
+    }
     Timber.d("--> EH: Finish syncing ${mangas.size} manga IDs!")
 }