Manga cover editing fixes

This commit is contained in:
Jobobby04 2020-07-13 13:25:05 -04:00
parent 923f5213cd
commit 294caa25a4
5 changed files with 8 additions and 12 deletions

View File

@ -18,7 +18,7 @@ class ChangelogDialogController : DialogController() {
val activity = activity!!
val view = WhatsNewRecyclerView(activity)
return MaterialDialog(activity)
.title(res = if (BuildConfig.DEBUG /* SY --> */ || syDebugVersion != "0" /* SY <-- */) R.string.notices else R.string.changelog)
.title(res = if (BuildConfig.DEBUG /* SY --> */ || syDebugVersion != "0" /* SY <-- */) R.string.notices else R.string.whats_new)
.customView(view = view)
.positiveButton(R.string.action_close)
}

View File

@ -334,8 +334,8 @@ class MangaController :
menu.findItem(R.id.download_group).isVisible = !isLocalSource
// Hide edit cover and migrate options for non-library manga
menu.findItem(R.id.action_edit_cover).isVisible = presenter.manga.favorite
/* SY --> menu.findItem(R.id.action_migrate).isVisible = presenter.manga.favorite SY <-- */
/* SY --> menu.findItem(R.id.action_edit_cover).isVisible = presenter.manga.favorite SY <-- */
/* SY --> menu.findItem(R.id.action_migrate).isVisible = presenter.manga.favorite SY <-- */
// SY -->
if (presenter.manga.favorite) menu.findItem(R.id.action_edit).isVisible = true
@ -407,7 +407,7 @@ class MangaController :
}
// SY <--
R.id.action_edit_cover -> handleChangeCover()
// SY --> R.id.action_edit_cover -> handleChangeCover() // SY <--
// SY --> R.id.action_migrate -> migrateManga() // SY <--
}
return super.onOptionsItemSelected(item)
@ -553,7 +553,7 @@ class MangaController :
REQUEST_EDIT_MANGA_COVER
)
} else {
activity?.toast(R.string.cover_must_be_in_library)
activity?.toast(R.string.notification_first_add_to_library)
}
}

View File

@ -240,6 +240,7 @@ class MangaPresenter(
editCoverWithStream(uri)
} else if (resetCover) {
coverCache.deleteCustomCover(manga)
manga.updateCoverLastModified(db)
}
if (uri == null && resetCover) {

View File

@ -97,10 +97,10 @@
</menu>
</item>
<item
<!--<item
android:id="@+id/action_edit_cover"
android:title="@string/action_edit_cover"
app:showAsAction="never" />
app:showAsAction="never" />-->
<!--<item
android:id="@+id/action_migrate"

View File

@ -33,10 +33,6 @@
<string name="ext_redundant">Redundant</string>
<string name="redundant_extension_message">This extension is redundant and will not be used inside this version of Tachiyomi.</string>
<!-- About Section -->
<string name="changelog">Changelog</string>
<!-- Library update service notifications -->
<string name="notification_new_chapters_text_old">For %1$d titles</string>
@ -132,7 +128,6 @@
<string name="add_tag">Add Tag</string>
<string name="cover_reset_toast">The cover will be updated when you exit manga info edit</string>
<string name="select_cover_image">Select cover image</string>
<string name="cover_must_be_in_library">Must be in library to edit cover images</string>
<string name="failed_to_update_cover">Failed to update cover</string>
<!-- AZ -->