[skip ci] Update CONTRIBUTING.md
This commit is contained in:
parent
40a2d4435a
commit
8d48368eb3
|
@ -193,7 +193,7 @@ apply from: "$rootDir/common.gradle"
|
|||
| `libVersion` | (Optional, defaults to `1.3`) The version of the [extensions library](https://github.com/tachiyomiorg/extensions-lib) used. |
|
||||
| `isNsfw` | (Optional, defaults to `false`) Flag to indicate that a source contains NSFW content. |
|
||||
|
||||
The extension's version name is generated automatically by concatenating `libVersion` and `extVersionCode`. With the example used above, the version would be `1.2.1`.
|
||||
The extension's version name is generated automatically by concatenating `libVersion` and `extVersionCode`. With the example used above, the version would be `1.3.1`.
|
||||
|
||||
### Core dependencies
|
||||
|
||||
|
@ -256,7 +256,7 @@ The class which is referenced and defined by `extClass` in `build.gradle`. This
|
|||
a.k.a. the Browse source entry point in the app (invoked by tapping on the source name).
|
||||
|
||||
- The app calls `fetchPopularManga` which should return a `MangasPage` containing the first batch of found `SManga` entries.
|
||||
- This method supports pagination. When user scrolls the manga list and more results must be fetched, the app calls it again with increasing `page` values (starting with `page=1`). This continues until `MangasPage.hasNextPage` is passed as `true` and `MangasPage.mangas` is not empty.
|
||||
- This method supports pagination. When user scrolls the manga list and more results must be fetched, the app calls it again with increasing `page` values (starting with `page=1`). This continues while `MangasPage.hasNextPage` is passed as `true` and `MangasPage.mangas` is not empty.
|
||||
- To show the list properly, the app needs `url`, `title` and `thumbnail_url`. You **must** set them here. The rest of the fields could be filled later (refer to Manga Details below).
|
||||
- You should set `thumbnail_url` if is available, if not, `fetchMangaDetails` will be **immediately** called (this will increase network calls heavily and should be avoided).
|
||||
|
||||
|
@ -331,7 +331,7 @@ open class UriPartFilter(displayName: String, private val vals: Array<Pair<Strin
|
|||
}
|
||||
}
|
||||
```
|
||||
|
||||
|
||||
Make sure you make the `SimpleDateFormat` a class constant or variable so it doesn't get recreated for every chapter. If you need to parse or format dates in manga description, create another instance since `SimpleDateFormat` is not thread-safe.
|
||||
- If the parsing have any problem, make sure to return `0L` so the app will use the default date instead.
|
||||
- The app will overwrite dates of existing old chapters **UNLESS** `0L` is returned.
|
||||
|
|
Loading…
Reference in New Issue