From d294bc0b2ae4cef289096bcb78eb5abecd5e3f65 Mon Sep 17 00:00:00 2001 From: Soitora Date: Thu, 2 Sep 2021 23:57:54 +0200 Subject: [PATCH] Add status icons to manga info (#5832) * Add icons to manga status * Slightly better formatting Mixed in with a dose of syntactic sugar * Remove unnecessary lines I think they are, at least * Change according to review comments - Fix forgotten Tablet code removal - Change 'android:background' to 'app:srcCompat' * Adjust size of icon Smaller and more fitting to the environment (cherry picked from commit d935e22f0df88d59e6e527cbc3db5dd7d908df35) # Conflicts: # app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt --- .../ui/manga/info/MangaInfoHeaderAdapter.kt | 24 ++++++++++--------- .../res/drawable/ic_status_completed_24dp.xml | 9 +++++++ .../res/drawable/ic_status_licensed_24dp.xml | 9 +++++++ .../res/drawable/ic_status_ongoing_24dp.xml | 9 +++++++ .../res/drawable/ic_status_unknown_24dp.xml | 9 +++++++ .../res/layout-sw720dp/manga_info_header.xml | 9 +++++++ app/src/main/res/layout/manga_info_header.xml | 9 +++++++ 7 files changed, 67 insertions(+), 11 deletions(-) create mode 100644 app/src/main/res/drawable/ic_status_completed_24dp.xml create mode 100644 app/src/main/res/drawable/ic_status_licensed_24dp.xml create mode 100644 app/src/main/res/drawable/ic_status_ongoing_24dp.xml create mode 100644 app/src/main/res/drawable/ic_status_unknown_24dp.xml diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt index 87d938164..4a8e02270 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt @@ -349,20 +349,22 @@ class MangaInfoHeaderAdapter( } } - // Update status TextView. - binding.mangaStatus.setText( - when (manga.status) { - SManga.ONGOING -> R.string.ongoing - SManga.COMPLETED -> R.string.completed - SManga.LICENSED -> R.string.licensed + // Update manga status. + binding.apply { + val (statusDrawable, statusString) = when (manga.status) { + SManga.ONGOING -> R.drawable.ic_status_ongoing_24dp to R.string.ongoing + SManga.COMPLETED -> R.drawable.ic_status_completed_24dp to R.string.completed + SManga.LICENSED -> R.drawable.ic_status_licensed_24dp to R.string.licensed // SY --> Mangadex specific statuses - SManga.HIATUS -> R.string.hiatus - SManga.PUBLICATION_COMPLETE -> R.string.publication_complete - SManga.CANCELLED -> R.string.cancelled + SManga.HIATUS -> R.drawable.ic_status_unknown_24dp to R.string.hiatus + SManga.PUBLICATION_COMPLETE -> R.drawable.ic_status_unknown_24dp to R.string.publication_complete + SManga.CANCELLED -> R.drawable.ic_status_unknown_24dp to R.string.cancelled // SY <-- - else -> R.string.unknown_status + else -> R.drawable.ic_status_unknown_24dp to R.string.unknown } - ) + mangaStatusIcon.setImageResource(statusDrawable) + mangaStatus.setText(statusString) + } // Set the favorite drawable to the correct one. setFavoriteButtonState(manga.favorite) diff --git a/app/src/main/res/drawable/ic_status_completed_24dp.xml b/app/src/main/res/drawable/ic_status_completed_24dp.xml new file mode 100644 index 000000000..2e2413479 --- /dev/null +++ b/app/src/main/res/drawable/ic_status_completed_24dp.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/drawable/ic_status_licensed_24dp.xml b/app/src/main/res/drawable/ic_status_licensed_24dp.xml new file mode 100644 index 000000000..ba6217217 --- /dev/null +++ b/app/src/main/res/drawable/ic_status_licensed_24dp.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/drawable/ic_status_ongoing_24dp.xml b/app/src/main/res/drawable/ic_status_ongoing_24dp.xml new file mode 100644 index 000000000..feebf134f --- /dev/null +++ b/app/src/main/res/drawable/ic_status_ongoing_24dp.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/drawable/ic_status_unknown_24dp.xml b/app/src/main/res/drawable/ic_status_unknown_24dp.xml new file mode 100644 index 000000000..7fa2fa53e --- /dev/null +++ b/app/src/main/res/drawable/ic_status_unknown_24dp.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/layout-sw720dp/manga_info_header.xml b/app/src/main/res/layout-sw720dp/manga_info_header.xml index d73114fb1..bffdcb2d0 100644 --- a/app/src/main/res/layout-sw720dp/manga_info_header.xml +++ b/app/src/main/res/layout-sw720dp/manga_info_header.xml @@ -95,6 +95,15 @@ android:layout_width="wrap_content" android:layout_height="wrap_content"> + + + +