From b9bddd264b78a41f286863ed41e499b7e2a16101 Mon Sep 17 00:00:00 2001 From: Andreas E Date: Sat, 24 Oct 2020 19:07:06 +0200 Subject: [PATCH] Update Global search layout to match Library and Browse (#3892) * Update Global Search card item to be comfortable with rounded corners * Remove card background (cherry picked from commit a2b1acd70f5d41ad34fa8320ececb7cb9869bf6b) # Conflicts: # app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchCardHolder.kt # app/src/main/res/layout/global_search_controller_card.xml # app/src/main/res/layout/global_search_controller_comfortable_card_item.xml --- .../ui/browse/latest/LatestCardHolder.kt | 9 ++- .../ui/browse/latest/LatestCardItem.kt | 8 +- .../ui/browse/latest/LatestHolder.kt | 3 - .../globalsearch/GlobalSearchCardHolder.kt | 9 ++- .../globalsearch/GlobalSearchCardItem.kt | 10 +-- .../source/globalsearch/GlobalSearchHolder.kt | 3 - .../ui/browse/source/index/IndexCardHolder.kt | 9 ++- .../ui/browse/source/index/IndexCardItem.kt | 9 +-- .../layout/global_search_controller_card.xml | 39 ++++------ .../global_search_controller_card_item.xml | 60 +++++++++++++++ ...earch_controller_comfortable_card_item.xml | 55 -------------- ...al_search_controller_compact_card_item.xml | 73 ------------------- app/src/main/res/layout/index_adapter.xml | 4 +- .../res/layout/latest_controller_card.xml | 37 ++++------ 14 files changed, 112 insertions(+), 216 deletions(-) create mode 100644 app/src/main/res/layout/global_search_controller_card_item.xml delete mode 100644 app/src/main/res/layout/global_search_controller_comfortable_card_item.xml delete mode 100644 app/src/main/res/layout/global_search_controller_compact_card_item.xml diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestCardHolder.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestCardHolder.kt index 360714a62..e12bccaba 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestCardHolder.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestCardHolder.kt @@ -7,9 +7,10 @@ import eu.kanade.tachiyomi.data.glide.GlideApp import eu.kanade.tachiyomi.data.glide.toMangaThumbnail import eu.kanade.tachiyomi.ui.base.holder.BaseFlexibleViewHolder import eu.kanade.tachiyomi.widget.StateImageViewTarget -import kotlinx.android.synthetic.main.global_search_controller_comfortable_card_item.itemImage -import kotlinx.android.synthetic.main.global_search_controller_comfortable_card_item.progress -import kotlinx.android.synthetic.main.global_search_controller_comfortable_card_item.tvTitle +import kotlinx.android.synthetic.main.global_search_controller_card_item.card +import kotlinx.android.synthetic.main.global_search_controller_card_item.itemImage +import kotlinx.android.synthetic.main.global_search_controller_card_item.progress +import kotlinx.android.synthetic.main.global_search_controller_card_item.tvTitle class LatestCardHolder(view: View, adapter: LatestCardAdapter) : BaseFlexibleViewHolder(view, adapter) { @@ -32,6 +33,8 @@ class LatestCardHolder(view: View, adapter: LatestCardAdapter) : } fun bind(manga: Manga) { + card.clipToOutline = true + tvTitle.text = manga.title // Set alpha of thumbnail. itemImage.alpha = if (manga.favorite) 0.3f else 1.0f diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestCardItem.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestCardItem.kt index 227e4f4d5..84333738d 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestCardItem.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestCardItem.kt @@ -7,18 +7,12 @@ import eu.davidea.flexibleadapter.items.AbstractFlexibleItem import eu.davidea.flexibleadapter.items.IFlexible import eu.kanade.tachiyomi.R import eu.kanade.tachiyomi.data.database.models.Manga -import eu.kanade.tachiyomi.data.preference.PreferenceValues -import eu.kanade.tachiyomi.data.preference.PreferencesHelper -import uy.kohesive.injekt.Injekt import uy.kohesive.injekt.api.get class LatestCardItem(val manga: Manga) : AbstractFlexibleItem() { override fun getLayoutRes(): Int { - return when (Injekt.get().sourceDisplayMode().get()) { - PreferenceValues.DisplayMode.COMPACT_GRID -> R.layout.global_search_controller_compact_card_item - else -> R.layout.global_search_controller_comfortable_card_item - } + return R.layout.global_search_controller_card_item } override fun createViewHolder(view: View, adapter: FlexibleAdapter>): LatestCardHolder { diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestHolder.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestHolder.kt index f402526cb..3630a99db 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestHolder.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/latest/LatestHolder.kt @@ -9,7 +9,6 @@ import eu.kanade.tachiyomi.ui.base.holder.BaseFlexibleViewHolder import kotlinx.android.synthetic.main.latest_controller_card.no_results_found import kotlinx.android.synthetic.main.latest_controller_card.progress import kotlinx.android.synthetic.main.latest_controller_card.recycler -import kotlinx.android.synthetic.main.latest_controller_card.source_card import kotlinx.android.synthetic.main.latest_controller_card.title import kotlinx.android.synthetic.main.latest_controller_card.title_wrapper import uy.kohesive.injekt.Injekt @@ -106,11 +105,9 @@ class LatestHolder(view: View, val adapter: LatestAdapter) : private fun showResultsHolder() { no_results_found.isVisible = false - source_card.isVisible = true } private fun showNoResults() { no_results_found.isVisible = true - source_card.isVisible = false } } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchCardHolder.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchCardHolder.kt index 1a1c76197..76fe9ae21 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchCardHolder.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchCardHolder.kt @@ -7,9 +7,10 @@ import eu.kanade.tachiyomi.data.glide.GlideApp import eu.kanade.tachiyomi.data.glide.toMangaThumbnail import eu.kanade.tachiyomi.ui.base.holder.BaseFlexibleViewHolder import eu.kanade.tachiyomi.widget.StateImageViewTarget -import kotlinx.android.synthetic.main.global_search_controller_comfortable_card_item.itemImage -import kotlinx.android.synthetic.main.global_search_controller_comfortable_card_item.progress -import kotlinx.android.synthetic.main.global_search_controller_comfortable_card_item.tvTitle +import kotlinx.android.synthetic.main.global_search_controller_card_item.card +import kotlinx.android.synthetic.main.global_search_controller_card_item.itemImage +import kotlinx.android.synthetic.main.global_search_controller_card_item.progress +import kotlinx.android.synthetic.main.global_search_controller_card_item.tvTitle class GlobalSearchCardHolder(view: View, adapter: GlobalSearchCardAdapter) : BaseFlexibleViewHolder(view, adapter) { @@ -32,6 +33,8 @@ class GlobalSearchCardHolder(view: View, adapter: GlobalSearchCardAdapter) : } fun bind(manga: Manga) { + card.clipToOutline = true + tvTitle.text = manga.title // Set alpha of thumbnail. itemImage.alpha = if (manga.favorite) 0.3f else 1.0f diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchCardItem.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchCardItem.kt index d2b8e6d23..47cb5b8eb 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchCardItem.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchCardItem.kt @@ -7,20 +7,12 @@ import eu.davidea.flexibleadapter.items.AbstractFlexibleItem import eu.davidea.flexibleadapter.items.IFlexible import eu.kanade.tachiyomi.R import eu.kanade.tachiyomi.data.database.models.Manga -import eu.kanade.tachiyomi.data.preference.PreferenceValues -import eu.kanade.tachiyomi.data.preference.PreferencesHelper -import uy.kohesive.injekt.Injekt import uy.kohesive.injekt.api.get class GlobalSearchCardItem(val manga: Manga) : AbstractFlexibleItem() { override fun getLayoutRes(): Int { - // SY --> - return when (Injekt.get().sourceDisplayMode().get()) { - PreferenceValues.DisplayMode.COMPACT_GRID -> R.layout.global_search_controller_compact_card_item - else -> R.layout.global_search_controller_comfortable_card_item - } - // SY <-- + return R.layout.global_search_controller_card_item } override fun createViewHolder(view: View, adapter: FlexibleAdapter>): GlobalSearchCardHolder { diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchHolder.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchHolder.kt index c66fec4c0..38b9d8de6 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchHolder.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/globalsearch/GlobalSearchHolder.kt @@ -8,7 +8,6 @@ import eu.kanade.tachiyomi.ui.base.holder.BaseFlexibleViewHolder import kotlinx.android.synthetic.main.global_search_controller_card.no_results_found import kotlinx.android.synthetic.main.global_search_controller_card.progress import kotlinx.android.synthetic.main.global_search_controller_card.recycler -import kotlinx.android.synthetic.main.global_search_controller_card.source_card import kotlinx.android.synthetic.main.global_search_controller_card.title import kotlinx.android.synthetic.main.global_search_controller_card.title_wrapper @@ -103,11 +102,9 @@ class GlobalSearchHolder(view: View, val adapter: GlobalSearchAdapter) : private fun showResultsHolder() { no_results_found.isVisible = false - source_card.isVisible = true } private fun showNoResults() { no_results_found.isVisible = true - source_card.isVisible = false } } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexCardHolder.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexCardHolder.kt index 8826453d2..b250cfb05 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexCardHolder.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexCardHolder.kt @@ -7,9 +7,10 @@ import eu.kanade.tachiyomi.data.glide.GlideApp import eu.kanade.tachiyomi.data.glide.toMangaThumbnail import eu.kanade.tachiyomi.ui.base.holder.BaseFlexibleViewHolder import eu.kanade.tachiyomi.widget.StateImageViewTarget -import kotlinx.android.synthetic.main.global_search_controller_comfortable_card_item.itemImage -import kotlinx.android.synthetic.main.global_search_controller_comfortable_card_item.progress -import kotlinx.android.synthetic.main.global_search_controller_comfortable_card_item.tvTitle +import kotlinx.android.synthetic.main.global_search_controller_card_item.card +import kotlinx.android.synthetic.main.global_search_controller_card_item.itemImage +import kotlinx.android.synthetic.main.global_search_controller_card_item.progress +import kotlinx.android.synthetic.main.global_search_controller_card_item.tvTitle class IndexCardHolder(view: View, adapter: IndexCardAdapter) : BaseFlexibleViewHolder(view, adapter) { @@ -32,6 +33,8 @@ class IndexCardHolder(view: View, adapter: IndexCardAdapter) : } fun bind(manga: Manga) { + card.clipToOutline = true + tvTitle.text = manga.title // Set alpha of thumbnail. itemImage.alpha = if (manga.favorite) 0.3f else 1.0f diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexCardItem.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexCardItem.kt index e56dafa0b..6a60b6e2e 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexCardItem.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexCardItem.kt @@ -7,19 +7,12 @@ import eu.davidea.flexibleadapter.items.AbstractFlexibleItem import eu.davidea.flexibleadapter.items.IFlexible import eu.kanade.tachiyomi.R import eu.kanade.tachiyomi.data.database.models.Manga -import eu.kanade.tachiyomi.data.preference.PreferenceValues -import eu.kanade.tachiyomi.data.preference.PreferencesHelper import eu.kanade.tachiyomi.ui.browse.latest.LatestCardItem -import uy.kohesive.injekt.Injekt -import uy.kohesive.injekt.api.get class IndexCardItem(val manga: Manga) : AbstractFlexibleItem() { override fun getLayoutRes(): Int { - return when (Injekt.get().sourceDisplayMode().get()) { - PreferenceValues.DisplayMode.COMPACT_GRID -> R.layout.global_search_controller_compact_card_item - else -> R.layout.global_search_controller_comfortable_card_item - } + return R.layout.global_search_controller_card_item } override fun createViewHolder(view: View, adapter: FlexibleAdapter>): IndexCardHolder { diff --git a/app/src/main/res/layout/global_search_controller_card.xml b/app/src/main/res/layout/global_search_controller_card.xml index 5f8b21dc0..25c2c08d3 100644 --- a/app/src/main/res/layout/global_search_controller_card.xml +++ b/app/src/main/res/layout/global_search_controller_card.xml @@ -48,30 +48,21 @@ android:text="@string/no_results_found" android:visibility="gone" /> - + + + android:clipToPadding="false" + android:orientation="horizontal" + android:paddingStart="12dp" + android:paddingEnd="12dp" + tools:listitem="@layout/global_search_controller_card_item" /> - - - - - - - \ No newline at end of file + diff --git a/app/src/main/res/layout/global_search_controller_card_item.xml b/app/src/main/res/layout/global_search_controller_card_item.xml new file mode 100644 index 000000000..5c2dca95f --- /dev/null +++ b/app/src/main/res/layout/global_search_controller_card_item.xml @@ -0,0 +1,60 @@ + + + + + + + + + + + + + + + + diff --git a/app/src/main/res/layout/global_search_controller_comfortable_card_item.xml b/app/src/main/res/layout/global_search_controller_comfortable_card_item.xml deleted file mode 100644 index 54074cc95..000000000 --- a/app/src/main/res/layout/global_search_controller_comfortable_card_item.xml +++ /dev/null @@ -1,55 +0,0 @@ - - - - - - - - - - \ No newline at end of file diff --git a/app/src/main/res/layout/global_search_controller_compact_card_item.xml b/app/src/main/res/layout/global_search_controller_compact_card_item.xml deleted file mode 100644 index 1e761d4de..000000000 --- a/app/src/main/res/layout/global_search_controller_compact_card_item.xml +++ /dev/null @@ -1,73 +0,0 @@ - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/app/src/main/res/layout/index_adapter.xml b/app/src/main/res/layout/index_adapter.xml index bea19d9f6..5f7924dee 100644 --- a/app/src/main/res/layout/index_adapter.xml +++ b/app/src/main/res/layout/index_adapter.xml @@ -75,7 +75,7 @@ android:orientation="horizontal" android:paddingStart="4dp" android:paddingEnd="4dp" - tools:listitem="@layout/global_search_controller_comfortable_card_item" /> + tools:listitem="@layout/global_search_controller_card_item" /> @@ -145,7 +145,7 @@ android:orientation="horizontal" android:paddingStart="4dp" android:paddingEnd="4dp" - tools:listitem="@layout/global_search_controller_comfortable_card_item" /> + tools:listitem="@layout/global_search_controller_card_item" /> diff --git a/app/src/main/res/layout/latest_controller_card.xml b/app/src/main/res/layout/latest_controller_card.xml index 635682f64..ae34c5c13 100644 --- a/app/src/main/res/layout/latest_controller_card.xml +++ b/app/src/main/res/layout/latest_controller_card.xml @@ -49,30 +49,21 @@ android:text="@string/no_results_found" android:visibility="gone" /> - + + - - - - - - + android:clipToPadding="false" + android:orientation="horizontal" + android:paddingStart="12dp" + android:paddingEnd="12dp" + tools:listitem="@layout/global_search_controller_card_item" /> \ No newline at end of file