diff --git a/app/build.gradle.kts b/app/build.gradle.kts index 496366950..72295aa1f 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -237,11 +237,10 @@ dependencies { implementation("com.afollestad.material-dialogs:datetime:$materialDialogsVersion") // Conductor - implementation("com.bluelinelabs:conductor:2.1.5") - implementation("com.bluelinelabs:conductor-support:2.1.5") { - exclude(group = "com.android.support") - } - implementation("com.github.tachiyomiorg:conductor-support-preference:2.0.1") + val conductorVersion = "3.0.0" + implementation("com.bluelinelabs:conductor:$conductorVersion") + implementation("com.bluelinelabs:conductor-viewpager:$conductorVersion") + implementation("com.github.tachiyomiorg:conductor-support-preference:$conductorVersion") // FlowBinding val flowbindingVersion = "1.0.0" diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt b/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt index 174047b66..40af964ad 100755 --- a/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt @@ -9,7 +9,7 @@ import com.tfcporciuncula.flow.FlowSharedPreferences import com.tfcporciuncula.flow.Preference import eu.kanade.tachiyomi.R import eu.kanade.tachiyomi.data.database.models.Manga -import eu.kanade.tachiyomi.data.preference.PreferenceValues.ThemeMode.* +import eu.kanade.tachiyomi.data.preference.PreferenceValues.ThemeMode.system import eu.kanade.tachiyomi.data.track.TrackService import eu.kanade.tachiyomi.data.track.anilist.Anilist import eu.kanade.tachiyomi.ui.library.setting.DisplayModeSetting diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt index 44e55b0fe..711a948a9 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt @@ -10,14 +10,12 @@ import androidx.viewbinding.ViewBinding import com.bluelinelabs.conductor.Controller import com.bluelinelabs.conductor.ControllerChangeHandler import com.bluelinelabs.conductor.ControllerChangeType -import com.bluelinelabs.conductor.RestoreViewOnCreateController import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.MainScope import kotlinx.coroutines.cancel import timber.log.Timber -abstract class BaseController(bundle: Bundle? = null) : - RestoreViewOnCreateController(bundle) { +abstract class BaseController(bundle: Bundle? = null) : Controller(bundle) { protected lateinit var binding: VB private set diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/DialogController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/DialogController.kt index 0e487cb03..643d8dcf9 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/DialogController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/DialogController.kt @@ -5,7 +5,7 @@ import android.os.Bundle import android.view.LayoutInflater import android.view.View import android.view.ViewGroup -import com.bluelinelabs.conductor.RestoreViewOnCreateController +import com.bluelinelabs.conductor.Controller import com.bluelinelabs.conductor.Router import com.bluelinelabs.conductor.RouterTransaction import com.bluelinelabs.conductor.changehandler.SimpleSwapChangeHandler @@ -17,7 +17,7 @@ import com.bluelinelabs.conductor.changehandler.SimpleSwapChangeHandler * * Implementations should override this class and implement [.onCreateDialog] to create a custom dialog, such as an [android.app.AlertDialog] */ -abstract class DialogController : RestoreViewOnCreateController { +abstract class DialogController : Controller { protected var dialog: Dialog? = null private set diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/BrowseController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/BrowseController.kt index 77dc91219..701d56d7c 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/BrowseController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/BrowseController.kt @@ -9,7 +9,7 @@ import com.bluelinelabs.conductor.ControllerChangeHandler import com.bluelinelabs.conductor.ControllerChangeType import com.bluelinelabs.conductor.Router import com.bluelinelabs.conductor.RouterTransaction -import com.bluelinelabs.conductor.support.RouterPagerAdapter +import com.bluelinelabs.conductor.viewpager.RouterPagerAdapter import com.google.android.material.badge.BadgeDrawable import com.google.android.material.tabs.TabLayout import com.jakewharton.rxrelay.PublishRelay diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/ExtensionController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/ExtensionController.kt index 1f7ccd16e..aeb37fdb1 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/ExtensionController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/ExtensionController.kt @@ -136,7 +136,7 @@ open class ExtensionController : } searchView.queryTextChanges() - .filter { router.backstack.lastOrNull()?.controller() == this } + .filter { router.backstack.lastOrNull()?.controller == this } .onEach { query = it.toString() drawExtensions() diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/advanced/process/MigrationListController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/advanced/process/MigrationListController.kt index c1cac0ef4..21b17c0c4 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/advanced/process/MigrationListController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/migration/advanced/process/MigrationListController.kt @@ -272,7 +272,7 @@ class MigrationListController(bundle: Bundle? = null) : override fun updateCount() { launchUI { - if (router.backstack.lastOrNull()?.controller() == this@MigrationListController) { + if (router.backstack.lastOrNull()?.controller == this@MigrationListController) { setTitle() } } @@ -408,16 +408,16 @@ class MigrationListController(bundle: Bundle? = null) : private fun navigateOut() { if (migratingManga?.size == 1) { launchUI { - val hasDetails = router.backstack.any { it.controller() is MangaController } + val hasDetails = router.backstack.any { it.controller is MangaController } if (hasDetails) { val manga = migratingManga?.firstOrNull()?.searchResult?.get()?.let { db.getManga(it).executeOnIO() } if (manga != null) { val newStack = router.backstack.filter { - it.controller() !is MangaController && - it.controller() !is MigrationListController && - it.controller() !is PreMigrationController + it.controller !is MangaController && + it.controller !is MigrationListController && + it.controller !is PreMigrationController } + MangaController(manga).withFadeTransaction() router.setBackstack(newStack, FadeChangeHandler()) return@launchUI diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/SourceFilterController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/SourceFilterController.kt index 37b255b48..c7947610e 100755 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/SourceFilterController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/SourceFilterController.kt @@ -186,7 +186,7 @@ class SourceFilterController : SettingsController() { } searchView.queryTextChanges() - .filter { router.backstack.lastOrNull()?.controller() == this } + .filter { router.backstack.lastOrNull()?.controller == this } .onEach { this.query = it.toString() drawSources() diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceController.kt index 1e2116fb2..a81a493a9 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceController.kt @@ -402,7 +402,7 @@ open class BrowseSourceController(bundle: Bundle) : searchItem.fixExpand( onExpand = { invalidateMenuOnExpand() }, onCollapse = { - if (router.backstackSize >= 2 && router.backstack[router.backstackSize - 2].controller() is GlobalSearchController) { + if (router.backstackSize >= 2 && router.backstack[router.backstackSize - 2].controller is GlobalSearchController) { router.popController(this) } else { nonSubmittedQuery = "" diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexController.kt index c39ced5cb..d2e47b1b3 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/index/IndexController.kt @@ -124,7 +124,7 @@ open class IndexController : } override fun onSearchViewQueryTextChange(newText: String?) { - if (router.backstack.lastOrNull()?.controller() == this) { + if (router.backstack.lastOrNull()?.controller == this) { presenter.query = newText ?: "" } } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt index b70ec4211..c4da21f02 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt @@ -734,7 +734,7 @@ class LibraryController( override fun onSearchViewQueryTextChange(newText: String?) { // Ignore events if this controller isn't at the top to avoid query being reset - if (router.backstack.lastOrNull()?.controller() == this) { + if (router.backstack.lastOrNull()?.controller == this) { presenter.query = newText ?: "" performSearch() } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt index 85a6c4d82..4321daca2 100755 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt @@ -245,7 +245,7 @@ class MainActivity : BaseViewBindingActivity() { } ) - syncActivityViewWithController(router.backstack.lastOrNull()?.controller()) + syncActivityViewWithController(router.backstack.lastOrNull()?.controller) if (savedInstanceState == null) { // Reset Incognito Mode on relaunch @@ -294,7 +294,7 @@ class MainActivity : BaseViewBindingActivity() { // Close BrowseSourceController and its MangaController child when incognito mode is disabled if (!it) { - val fg = router.backstack.last().controller() + val fg = router.backstack.last().controller if (fg is BrowseSourceController || fg is MangaController && fg.fromSource) { router.popToRoot() } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaController.kt index 73b76afcb..7493f988c 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaController.kt @@ -958,7 +958,7 @@ class MangaController : return } - when (val previousController = router.backstack[router.backstackSize - 2].controller()) { + when (val previousController = router.backstack[router.backstackSize - 2].controller) { is LibraryController -> { router.handleBack() previousController.search(query) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/recent/history/HistoryController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/recent/history/HistoryController.kt index 91ac55550..511acf043 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/recent/history/HistoryController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/recent/history/HistoryController.kt @@ -194,7 +194,7 @@ class HistoryController : searchView.clearFocus() } searchView.queryTextChanges() - .filter { router.backstack.lastOrNull()?.controller() == this } + .filter { router.backstack.lastOrNull()?.controller == this } .onEach { query = it.toString() presenter.updateList(query)