From b3ddc1dfa3fc9a8f593c40af74f8b8ec0ca3beb2 Mon Sep 17 00:00:00 2001 From: Ivan Iskandar <12537387+ivaniskandar@users.noreply.github.com> Date: Sat, 22 May 2021 21:10:41 +0700 Subject: [PATCH] Remove material-design-dimens (#5133) (cherry picked from commit afd59eabbb5071b358f8dc04752788d73e4cc553) --- app/build.gradle.kts | 1 - app/src/main/res/layout/categories_item.xml | 7 ++++--- .../layout/common_dialog_with_checkbox.xml | 2 +- app/src/main/res/layout/download_item.xml | 15 +++++++------- .../res/layout/edit_merged_settings_item.xml | 2 +- .../layout/global_search_controller_card.xml | 8 ++++---- app/src/main/res/layout/index_controller.xml | 20 +++++++++---------- .../res/layout/latest_controller_card.xml | 8 ++++---- .../main/res/layout/migration_source_item.xml | 18 ++++++++--------- .../res/layout/navigation_view_checkbox.xml | 2 +- .../layout/navigation_view_checkedtext.xml | 2 +- .../main/res/layout/navigation_view_radio.xml | 2 +- app/src/main/res/layout/reader_activity.xml | 20 +++++++++---------- .../layout/reader_color_filter_settings.xml | 2 +- .../main/res/layout/section_header_item.xml | 6 ++---- app/src/main/res/layout/source_list_item.xml | 6 +++--- app/src/main/res/layout/updates_item.xml | 2 +- app/src/main/res/values-sw600dp/dimens.xml | 4 ++++ app/src/main/res/values/dimens.xml | 2 ++ app/src/main/res/values/styles.xml | 16 +++++---------- 20 files changed, 72 insertions(+), 73 deletions(-) create mode 100644 app/src/main/res/values-sw600dp/dimens.xml diff --git a/app/build.gradle.kts b/app/build.gradle.kts index b1e6a9cf0..49288a92f 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -219,7 +219,6 @@ dependencies { implementation("com.github.gpanther:java-nat-sort:natural-comparator-1.1") // UI - implementation("com.dmitrymalkovich.android:material-design-dimens:1.4") implementation("com.github.dmytrodanylyk.android-process-button:library:1.0.4") implementation("eu.davidea:flexible-adapter:5.1.0") implementation("eu.davidea:flexible-adapter-ui:1.0.0") diff --git a/app/src/main/res/layout/categories_item.xml b/app/src/main/res/layout/categories_item.xml index 2bbd5b8d1..c5bf5edc3 100755 --- a/app/src/main/res/layout/categories_item.xml +++ b/app/src/main/res/layout/categories_item.xml @@ -3,13 +3,14 @@ xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" - android:layout_height="@dimen/material_component_lists_single_line_with_avatar_height" + android:layout_height="56dp" android:background="@drawable/list_item_selector_background"> diff --git a/app/src/main/res/layout/download_item.xml b/app/src/main/res/layout/download_item.xml index bf8bfbe1e..076ed5e15 100755 --- a/app/src/main/res/layout/download_item.xml +++ b/app/src/main/res/layout/download_item.xml @@ -4,14 +4,15 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingTop="@dimen/material_component_lists_padding_above_list"> + android:paddingTop="8dp"> diff --git a/app/src/main/res/layout/index_controller.xml b/app/src/main/res/layout/index_controller.xml index 971240638..710b7f4e8 100644 --- a/app/src/main/res/layout/index_controller.xml +++ b/app/src/main/res/layout/index_controller.xml @@ -22,7 +22,7 @@ style="@style/TextAppearance.Regular.SubHeading" android:layout_width="0dp" android:layout_height="wrap_content" - android:padding="@dimen/material_component_text_fields_padding_above_and_below_label" + android:padding="16dp" android:text="@string/latest" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toStartOf="@+id/latest_bar_more_icon" @@ -34,7 +34,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:contentDescription="@string/label_more" - android:padding="@dimen/material_component_text_fields_padding_above_and_below_label" + android:padding="16dp" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toTopOf="parent" @@ -47,9 +47,9 @@ android:id="@+id/latest_no_results_found" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingStart="@dimen/material_component_text_fields_padding_above_and_below_label" - android:paddingEnd="@dimen/material_component_text_fields_padding_above_and_below_label" - android:paddingBottom="@dimen/material_component_text_fields_padding_above_and_below_label" + android:paddingStart="16dp" + android:paddingEnd="16dp" + android:paddingBottom="16dp" android:text="@string/no_results_found" android:visibility="gone" /> @@ -87,7 +87,7 @@ style="@style/TextAppearance.Regular.SubHeading" android:layout_width="0dp" android:layout_height="wrap_content" - android:padding="@dimen/material_component_text_fields_padding_above_and_below_label" + android:padding="16dp" android:text="@string/browse" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toStartOf="@+id/browse_bar_more_icon" @@ -99,7 +99,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:contentDescription="@string/label_more" - android:padding="@dimen/material_component_text_fields_padding_above_and_below_label" + android:padding="16dp" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toTopOf="parent" @@ -112,9 +112,9 @@ android:id="@+id/browse_no_results_found" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingStart="@dimen/material_component_text_fields_padding_above_and_below_label" - android:paddingEnd="@dimen/material_component_text_fields_padding_above_and_below_label" - android:paddingBottom="@dimen/material_component_text_fields_padding_above_and_below_label" + android:paddingStart="16dp" + android:paddingEnd="16dp" + android:paddingBottom="16dp" android:text="@string/no_results_found" android:visibility="gone" /> diff --git a/app/src/main/res/layout/latest_controller_card.xml b/app/src/main/res/layout/latest_controller_card.xml index 0e9b04c34..238a68999 100644 --- a/app/src/main/res/layout/latest_controller_card.xml +++ b/app/src/main/res/layout/latest_controller_card.xml @@ -46,7 +46,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:contentDescription="@string/label_more" - android:padding="@dimen/material_component_text_fields_padding_above_and_below_label" + android:padding="16dp" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toTopOf="parent" @@ -60,9 +60,9 @@ android:id="@+id/no_results_found" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingStart="@dimen/material_component_text_fields_padding_above_and_below_label" - android:paddingEnd="@dimen/material_component_text_fields_padding_above_and_below_label" - android:paddingBottom="@dimen/material_component_text_fields_padding_above_and_below_label" + android:paddingStart="16dp" + android:paddingEnd="16dp" + android:paddingBottom="16dp" android:text="@string/no_results_found" android:visibility="gone" /> diff --git a/app/src/main/res/layout/migration_source_item.xml b/app/src/main/res/layout/migration_source_item.xml index a02f91533..17b88e296 100644 --- a/app/src/main/res/layout/migration_source_item.xml +++ b/app/src/main/res/layout/migration_source_item.xml @@ -4,14 +4,14 @@ xmlns:tools="http://schemas.android.com/tools" xmlns:app="http://schemas.android.com/apk/res-auto" android:layout_width="match_parent" - android:layout_height="@dimen/material_component_lists_single_line_with_avatar_height" + android:layout_height="56dp" android:background="@drawable/list_item_selector_background"> @@ -19,8 +19,8 @@ android:id="@+id/title" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginStart="@dimen/material_component_lists_text_left_padding" - android:layout_marginEnd="@dimen/material_component_lists_single_line_with_avatar_height" + android:layout_marginStart="72dp" + android:layout_marginEnd="56dp" android:ellipsize="end" android:maxLines="1" android:layout_gravity="center_vertical" @@ -29,11 +29,11 @@ + app:tint="?android:attr/textColorPrimary" /> \ No newline at end of file diff --git a/app/src/main/res/layout/navigation_view_checkbox.xml b/app/src/main/res/layout/navigation_view_checkbox.xml index 6dfab038a..2c36b7bf4 100755 --- a/app/src/main/res/layout/navigation_view_checkbox.xml +++ b/app/src/main/res/layout/navigation_view_checkbox.xml @@ -16,7 +16,7 @@ android:clickable="false" android:gravity="center_vertical|start" android:maxLines="1" - android:paddingStart="@dimen/material_component_lists_icon_left_padding" + android:paddingHorizontal="16dp" android:textAppearance="@style/TextAppearance.AppCompat.Body1" /> diff --git a/app/src/main/res/layout/navigation_view_checkedtext.xml b/app/src/main/res/layout/navigation_view_checkedtext.xml index 250a9fcf5..51243946c 100755 --- a/app/src/main/res/layout/navigation_view_checkedtext.xml +++ b/app/src/main/res/layout/navigation_view_checkedtext.xml @@ -12,7 +12,7 @@ android:layout_width="0dp" android:layout_height="match_parent" android:layout_weight="1" - android:drawablePadding="@dimen/material_component_lists_icon_left_padding" + android:drawablePadding="16dp" android:gravity="center_vertical|start" android:maxLines="1" android:textAppearance="@style/TextAppearance.AppCompat.Body1" /> diff --git a/app/src/main/res/layout/navigation_view_radio.xml b/app/src/main/res/layout/navigation_view_radio.xml index 8e1201998..7ac1d6687 100755 --- a/app/src/main/res/layout/navigation_view_radio.xml +++ b/app/src/main/res/layout/navigation_view_radio.xml @@ -16,7 +16,7 @@ android:clickable="false" android:gravity="center_vertical|start" android:maxLines="1" - android:paddingStart="@dimen/material_component_lists_icon_left_padding" + android:paddingHorizontal="16dp" android:textAppearance="@style/TextAppearance.AppCompat.Body1" /> diff --git a/app/src/main/res/layout/reader_activity.xml b/app/src/main/res/layout/reader_activity.xml index 9e14353d4..173276e57 100755 --- a/app/src/main/res/layout/reader_activity.xml +++ b/app/src/main/res/layout/reader_activity.xml @@ -202,7 +202,7 @@ android:layout_marginBottom="8dp" android:background="@drawable/reader_seekbar_button" android:contentDescription="@string/action_previous_chapter" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" android:rotation="90" app:srcCompat="@drawable/ic_skip_previous_24dp" app:tint="?attr/colorOnPrimary" /> @@ -269,7 +269,7 @@ android:layout_marginBottom="80dp" android:background="@drawable/reader_seekbar_button" android:contentDescription="@string/action_next_chapter" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" android:rotation="90" app:srcCompat="@drawable/ic_skip_next_24dp" app:tint="?attr/colorOnPrimary" /> @@ -313,7 +313,7 @@ android:layout_marginEnd="8dp" android:background="@drawable/reader_seekbar_button" android:contentDescription="@string/action_previous_chapter" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" app:srcCompat="@drawable/ic_skip_previous_24dp" app:tint="?attr/colorOnPrimary" /> @@ -365,7 +365,7 @@ android:layout_marginStart="8dp" android:background="@drawable/reader_seekbar_button" android:contentDescription="@string/action_next_chapter" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" app:srcCompat="@drawable/ic_skip_next_24dp" app:tint="?attr/colorOnPrimary" /> @@ -383,7 +383,7 @@ android:layout_height="match_parent" android:background="?selectableItemBackgroundBorderless" android:contentDescription="@string/custom_filter" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" app:layout_constraintEnd_toStartOf="@+id/action_web_view" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" @@ -397,7 +397,7 @@ android:layout_height="match_parent" android:background="?selectableItemBackgroundBorderless" android:contentDescription="@string/custom_filter" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" app:layout_constraintEnd_toStartOf="@id/action_reading_mode" app:layout_constraintStart_toEndOf="@+id/action_chapter_list" app:layout_constraintTop_toTopOf="parent" @@ -411,7 +411,7 @@ android:layout_height="match_parent" android:background="?selectableItemBackgroundBorderless" android:contentDescription="@string/viewer" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" app:layout_constraintEnd_toStartOf="@id/action_crop_borders" app:layout_constraintStart_toEndOf="@+id/action_web_view" app:layout_constraintTop_toTopOf="parent" @@ -425,7 +425,7 @@ android:layout_height="match_parent" android:background="?selectableItemBackgroundBorderless" android:contentDescription="@string/pref_crop_borders" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" app:layout_constraintEnd_toStartOf="@id/action_rotation" app:layout_constraintStart_toEndOf="@+id/action_reading_mode" app:layout_constraintTop_toTopOf="parent" @@ -439,7 +439,7 @@ android:layout_height="match_parent" android:background="?selectableItemBackgroundBorderless" android:contentDescription="@string/pref_rotation_type" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" app:layout_constraintEnd_toStartOf="@id/action_settings" app:layout_constraintStart_toEndOf="@+id/action_crop_borders" app:layout_constraintTop_toTopOf="parent" @@ -453,7 +453,7 @@ android:layout_height="match_parent" android:background="?selectableItemBackgroundBorderless" android:contentDescription="@string/action_settings" - android:padding="@dimen/material_layout_keylines_screen_edge_margin" + android:padding="@dimen/screen_edge_margin" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toEndOf="@id/action_rotation" app:layout_constraintTop_toTopOf="parent" diff --git a/app/src/main/res/layout/reader_color_filter_settings.xml b/app/src/main/res/layout/reader_color_filter_settings.xml index 9701574f7..65288cddf 100644 --- a/app/src/main/res/layout/reader_color_filter_settings.xml +++ b/app/src/main/res/layout/reader_color_filter_settings.xml @@ -225,7 +225,7 @@ android:layout_height="wrap_content" android:layout_marginStart="8dp" android:layout_marginEnd="8dp" - android:padding="@dimen/material_component_text_fields_floating_label_padding_between_label_and_input_text" + android:padding="8dp" app:layout_constraintEnd_toStartOf="@id/txt_brightness_seekbar_value" app:layout_constraintStart_toEndOf="@id/txt_brightness_seekbar_icon" app:layout_constraintTop_toBottomOf="@id/custom_brightness" diff --git a/app/src/main/res/layout/section_header_item.xml b/app/src/main/res/layout/section_header_item.xml index 0e3651855..45eba41e8 100644 --- a/app/src/main/res/layout/section_header_item.xml +++ b/app/src/main/res/layout/section_header_item.xml @@ -9,10 +9,8 @@ style="@style/TextAppearance.Medium.SubHeading" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingStart="@dimen/material_component_text_fields_padding_above_and_below_label" - android:paddingTop="8dp" - android:paddingEnd="@dimen/material_component_text_fields_padding_above_and_below_label" - android:paddingBottom="8dp" + android:paddingHorizontal="16dp" + android:paddingVertical="8dp" tools:text="Title" /> diff --git a/app/src/main/res/layout/source_list_item.xml b/app/src/main/res/layout/source_list_item.xml index 63c1272db..e25d6019d 100644 --- a/app/src/main/res/layout/source_list_item.xml +++ b/app/src/main/res/layout/source_list_item.xml @@ -3,7 +3,7 @@ xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" - android:layout_height="@dimen/material_component_lists_single_line_with_avatar_height" + android:layout_height="56dp" android:layout_gravity="center_vertical" android:background="@drawable/list_item_selector_background" android:paddingStart="8dp" @@ -11,8 +11,8 @@ diff --git a/app/src/main/res/values-sw600dp/dimens.xml b/app/src/main/res/values-sw600dp/dimens.xml new file mode 100644 index 000000000..fc0bcc36e --- /dev/null +++ b/app/src/main/res/values-sw600dp/dimens.xml @@ -0,0 +1,4 @@ + + + 24dp + diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index c9b5a656f..dabe27907 100755 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -12,4 +12,6 @@ 88dp 72dp + + 16dp diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index a2ae5ab5f..59f02cb11 100755 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -189,17 +189,11 @@