From ae3f974d8c33ff7693069a94017bc1bc493cf545 Mon Sep 17 00:00:00 2001 From: AntsyLich <59261191+AntsyLich@users.noreply.github.com> Date: Mon, 31 Mar 2025 11:09:10 +0600 Subject: [PATCH] Fix user notes not restoring when manga doesn't exist in DB (#1945) (cherry picked from commit e91db86faef8d6b17961a1b73fbf07f0d2c8975d) # Conflicts: # CHANGELOG.md --- .../data/backup/restore/restorers/MangaRestorer.kt | 1 + .../main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt | 1 + data/src/main/sqldelight/tachiyomi/data/mangas.sq | 8 ++++---- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt b/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt index 91003d09d..0566a7f4c 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt @@ -293,6 +293,7 @@ class MangaRestorer( dateAdded = manga.dateAdded, updateStrategy = manga.updateStrategy, version = manga.version, + notes = manga.notes, ) mangasQueries.selectLastInsertedRowId() } diff --git a/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt b/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt index 50a7827ce..0940da181 100644 --- a/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt +++ b/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt @@ -133,6 +133,7 @@ class MangaRepositoryImpl( dateAdded = manga.dateAdded, updateStrategy = manga.updateStrategy, version = manga.version, + notes = manga.notes, ) mangasQueries.selectLastInsertedRowId() } diff --git a/data/src/main/sqldelight/tachiyomi/data/mangas.sq b/data/src/main/sqldelight/tachiyomi/data/mangas.sq index 0628c3226..6ee571ef9 100644 --- a/data/src/main/sqldelight/tachiyomi/data/mangas.sq +++ b/data/src/main/sqldelight/tachiyomi/data/mangas.sq @@ -84,8 +84,8 @@ getReadMangaNotInLibrary: SELECT * FROM mangas WHERE favorite = 0 AND _id IN ( - SELECT DISTINCT chapters.manga_id - FROM chapters + SELECT DISTINCT chapters.manga_id + FROM chapters WHERE read = 1 OR last_page_read != 0 ); @@ -163,8 +163,8 @@ WHERE favorite = 0 AND source IN :sourceIdsAND AND _id NOT IN ( ); insert: -INSERT INTO mangas(source, url, artist, author, description, genre, title, status, thumbnail_url, favorite, last_update, next_update, initialized, viewer, chapter_flags, cover_last_modified, date_added, update_strategy, calculate_interval, last_modified_at, version) -VALUES (:source, :url, :artist, :author, :description, :genre, :title, :status, :thumbnailUrl, :favorite, :lastUpdate, :nextUpdate, :initialized, :viewerFlags, :chapterFlags, :coverLastModified, :dateAdded, :updateStrategy, :calculateInterval, 0, :version); +INSERT INTO mangas(source, url, artist, author, description, genre, title, status, thumbnail_url, favorite, last_update, next_update, initialized, viewer, chapter_flags, cover_last_modified, date_added, update_strategy, calculate_interval, last_modified_at, version, notes) +VALUES (:source, :url, :artist, :author, :description, :genre, :title, :status, :thumbnailUrl, :favorite, :lastUpdate, :nextUpdate, :initialized, :viewerFlags, :chapterFlags, :coverLastModified, :dateAdded, :updateStrategy, :calculateInterval, 0, :version, :notes); update: UPDATE mangas SET