From 6574fed71aad423016df61ef4d37190293a34bee Mon Sep 17 00:00:00 2001 From: arkon Date: Mon, 8 Jun 2020 18:26:20 -0400 Subject: [PATCH] Switch to AboutLibraries (cherry picked from commit 77531613325d32d64f543b96b02587a253949ecf) # Conflicts: # app/build.gradle # app/src/main/java/eu/kanade/tachiyomi/ui/more/AboutController.kt # build.gradle.kts --- app/build.gradle | 10 +++++++++- .../eu/kanade/tachiyomi/ui/more/AboutController.kt | 11 ++++++++--- app/src/main/res/values/strings.xml | 2 +- build.gradle.kts | 2 +- 4 files changed, 19 insertions(+), 6 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 611111bb8..de34ad064 100755 --- a/app/build.gradle +++ b/app/build.gradle @@ -3,7 +3,7 @@ import org.jetbrains.kotlin.gradle.tasks.AbstractKotlinCompile import java.text.SimpleDateFormat apply plugin: 'com.android.application' -apply plugin: 'com.google.android.gms.oss-licenses-plugin' +apply plugin: 'com.mikepenz.aboutlibraries.plugin' apply plugin: 'kotlin-android' apply plugin: 'kotlin-android-extensions' apply plugin: 'kotlin-kapt' @@ -90,6 +90,9 @@ android { buildConfigField "boolean", "INCLUDE_UPDATER", "true" dimension "default" } + fdroid { + dimension "default" + } dev { resConfigs "en", "xxhdpi" dimension "default" @@ -274,6 +277,11 @@ dependencies { implementation "io.github.reactivecircus.flowbinding:flowbinding-swiperefreshlayout:$flowbinding_version" implementation "io.github.reactivecircus.flowbinding:flowbinding-viewpager:$flowbinding_version" + // Licenses + final aboutlibraries_version = '8.2.0' + implementation "com.mikepenz:aboutlibraries-core:$aboutlibraries_version" + implementation "com.mikepenz:aboutlibraries:$aboutlibraries_version" + // Tests testImplementation 'junit:junit:4.13' testImplementation 'org.assertj:assertj-core:3.12.2' diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/more/AboutController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/more/AboutController.kt index ad0455dcf..09406137c 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/more/AboutController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/more/AboutController.kt @@ -7,7 +7,7 @@ import android.os.Build import android.os.Bundle import androidx.preference.PreferenceScreen import com.afollestad.materialdialogs.MaterialDialog -import com.google.android.gms.oss.licenses.OssLicensesMenuActivity +import com.mikepenz.aboutlibraries.LibsBuilder import eu.kanade.tachiyomi.BuildConfig import eu.kanade.tachiyomi.R import eu.kanade.tachiyomi.data.updater.UpdateChecker @@ -125,7 +125,12 @@ class AboutController : SettingsController() { titleRes = R.string.licenses onClick { - startActivity(Intent(activity, OssLicensesMenuActivity::class.java)) + LibsBuilder() + .withActivityTitle(activity!!.getString(R.string.licenses)) + .withAboutIconShown(false) + .withAboutVersionShown(false) + .withLicenseShown(true) + .start(activity!!) } } } @@ -210,7 +215,7 @@ class AboutController : SettingsController() { return try { val inputDf = SimpleDateFormat("yyyy-MM-dd'T'HH:mm'Z'", Locale.US) inputDf.timeZone = TimeZone.getTimeZone("UTC") - val buildTime = inputDf.parse(BuildConfig.BUILD_TIME)!! + val buildTime = inputDf.parse(BuildConfig.BUILD_TIME) val outputDf = DateFormat.getDateTimeInstance( DateFormat.MEDIUM, DateFormat.SHORT, Locale.getDefault() diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index b6dd979ff..e2954da98 100755 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -367,7 +367,7 @@ Cookies cleared Dialog choices reset Clear database - Delete history for manga that are not in saved your library + Delete history for manga that are not saved in your library Are you sure? Read chapters and progress of non-library manga will be lost Entries deleted Refresh library manga covers diff --git a/build.gradle.kts b/build.gradle.kts index aee5d3c75..37a6e9da3 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -42,7 +42,7 @@ buildscript { classpath("com.github.ben-manes:gradle-versions-plugin:0.28.0") classpath("com.github.zellius:android-shortcut-gradle-plugin:0.1.2") classpath("com.google.gms:google-services:4.3.3") - classpath("com.google.android.gms:oss-licenses-plugin:0.10.2") + classpath("com.mikepenz.aboutlibraries.plugin:aboutlibraries-plugin:8.2.0") // Realm (EH) classpath("io.realm:realm-gradle-plugin:6.0.2")