From 606101dc8bf63c1d8dcd92162c5407fc19382c29 Mon Sep 17 00:00:00 2001 From: Soitora Date: Mon, 24 May 2021 17:16:32 +0200 Subject: [PATCH] Add "Midnight Dusk" and "Hot Pink" themes (#5161) * Organize and clarify themes file Increases clarification with better commenting, should make it easier to add or modify current themes. * Make AMOLED its own theme category * Tweak ripples for AMOLED * Add "Midnight Dusk" theme Ports it from jobobby04/TachiyomiSY. Co-Authored-By: CrepeTF <70870719+CrepeTF@users.noreply.github.com> * Add "Hot Pink" theme Ports it from jobobby04/TachiyomiSY. Co-Authored-By: OncePunchedMan <64155117+OncePunchedMan@users.noreply.github.com> * Make AMOLED a base theme * Final tweaks Rename "Toolbar.Light" to "Custom.PopupTheme" Changes placing of backgroundDusk Removes HotPink and MidnightDusk custom Toolbars, I believe they are unnecessary. * Rename a Midnight Dusk color * Make AMOLED independent from Dark as a theme Co-authored-by: CrepeTF <70870719+CrepeTF@users.noreply.github.com> Co-authored-by: OncePunchedMan <64155117+OncePunchedMan@users.noreply.github.com> (cherry picked from commit 176e984b56d66d1e47bd367d7dde03e4a024152c) # Conflicts: # app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferenceValues.kt # app/src/main/java/eu/kanade/tachiyomi/ui/base/activity/BaseThemedActivity.kt # app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsGeneralController.kt # app/src/main/res/values/styles.xml # app/src/main/res/values/themes.xml --- .../data/preference/PreferenceValues.kt | 6 +- .../ui/base/activity/BaseThemedActivity.kt | 8 +- .../ui/setting/SettingsGeneralController.kt | 14 +- app/src/main/res/values-ru/strings_sy.xml | 2 - app/src/main/res/values/colors.xml | 24 +- app/src/main/res/values/strings.xml | 2 + app/src/main/res/values/strings_sy.xml | 2 - app/src/main/res/values/styles.xml | 44 +--- app/src/main/res/values/styles_sy.xml | 25 ++ app/src/main/res/values/themes.xml | 232 +++++++++++++++--- app/src/main/res/values/themes_sy.xml | 49 +--- 11 files changed, 269 insertions(+), 139 deletions(-) create mode 100644 app/src/main/res/values/styles_sy.xml diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferenceValues.kt b/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferenceValues.kt index 7a79738d6..4d722cb8f 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferenceValues.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferenceValues.kt @@ -24,11 +24,11 @@ object PreferenceValues { enum class DarkThemeVariant { default, blue, - amoledblue, - amoled, - red, midnightdusk, + amoled, hotpink, + amoledblue, + red, } /* ktlint-enable experimental:enum-entry-name-case */ diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/base/activity/BaseThemedActivity.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/base/activity/BaseThemedActivity.kt index d80c47bec..8f393f2ae 100755 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/base/activity/BaseThemedActivity.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/base/activity/BaseThemedActivity.kt @@ -25,11 +25,11 @@ abstract class BaseThemedActivity : AppCompatActivity() { when (preferences.themeDark().get()) { DarkThemeVariant.default -> R.style.Theme_Tachiyomi_Dark DarkThemeVariant.blue -> R.style.Theme_Tachiyomi_Dark_Blue - DarkThemeVariant.amoledblue -> R.style.Theme_Tachiyomi_Dark_AmoledBlue - DarkThemeVariant.amoled -> R.style.Theme_Tachiyomi_Dark_Amoled - DarkThemeVariant.red -> R.style.Theme_Tachiyomi_Dark_Red DarkThemeVariant.midnightdusk -> R.style.Theme_Tachiyomi_Dark_MidnightDusk - DarkThemeVariant.hotpink -> R.style.Theme_Tachiyomi_Dark_HotPink + DarkThemeVariant.amoled -> R.style.Theme_Tachiyomi_Amoled + DarkThemeVariant.hotpink -> R.style.Theme_Tachiyomi_Amoled_HotPink + DarkThemeVariant.amoledblue -> R.style.Theme_Tachiyomi_Amoled_Blue + DarkThemeVariant.red -> R.style.Theme_Tachiyomi_Dark_Red } } else { when (preferences.themeLight().get()) { diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsGeneralController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsGeneralController.kt index 6395a0771..de85aa175 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsGeneralController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsGeneralController.kt @@ -156,20 +156,20 @@ class SettingsGeneralController : SettingsController() { entriesRes = arrayOf( R.string.theme_dark_default, R.string.theme_dark_blue, - R.string.theme_dark_amoledblue, - R.string.theme_dark_amoled, - R.string.theme_dark_red, R.string.theme_dark_midnightdusk, - R.string.theme_dark_hotpink, + R.string.theme_dark_amoled, + R.string.theme_dark_amoled_hotpink, + R.string.theme_dark_amoledblue, + R.string.theme_dark_red ) entryValues = arrayOf( Values.DarkThemeVariant.default.name, Values.DarkThemeVariant.blue.name, - Values.DarkThemeVariant.amoledblue.name, - Values.DarkThemeVariant.amoled.name, - Values.DarkThemeVariant.red.name, Values.DarkThemeVariant.midnightdusk.name, + Values.DarkThemeVariant.amoled.name, Values.DarkThemeVariant.hotpink.name, + Values.DarkThemeVariant.amoledblue.name, + Values.DarkThemeVariant.red.name ) defaultValue = Values.DarkThemeVariant.default.name summary = "%s" diff --git a/app/src/main/res/values-ru/strings_sy.xml b/app/src/main/res/values-ru/strings_sy.xml index b6579526c..77a9e8822 100644 --- a/app/src/main/res/values-ru/strings_sy.xml +++ b/app/src/main/res/values-ru/strings_sy.xml @@ -699,6 +699,4 @@ AMOLED синяя Чёрное и Красное - Полуночные Сумерки - Горячий Розовый diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml index c9eec40ee..4e86a694c 100755 --- a/app/src/main/res/values/colors.xml +++ b/app/src/main/res/values/colors.xml @@ -8,8 +8,11 @@ #242529 #202125 + + @color/md_black_1000 + @color/colorPrimary @@ -48,19 +51,30 @@ @color/md_white_1000_70 @color/md_white_1000_50 #12ffffff - #0FF02475 + #0FF02475 #16151D #201F27 #80F02475 + + #3399FF + @color/md_white_1000 + @color/md_white_1000_70 + @color/md_white_1000_50 + @android:color/transparent + @color/md_white_1000_8 + #0A3399FF + @color/rippleColorAmoled + @color/colorAmoledPrimary + @color/colorAmoledPrimary + @color/md_blue_A200_50 + #FF3399 @color/md_white_1000 @color/md_white_1000_70 @color/md_white_1000_50 - #0FFF3399 - @color/md_black_1000 - @color/md_black_1000 + #0AFF3399 #80FF69B4 @@ -70,12 +84,14 @@ #FFC107 #FFEB3B + #FFEB3B #DE000000 #8A000000 #61000000 #1F000000 + #14000000 #0F000000 #FFFFFFFF diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 56232c060..76256d554 100755 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -159,7 +159,9 @@ Dark theme Default Dark blue + Midnight dusk AMOLED black + Hot pink Start screen Language Default diff --git a/app/src/main/res/values/strings_sy.xml b/app/src/main/res/values/strings_sy.xml index 87c538118..26e390369 100644 --- a/app/src/main/res/values/strings_sy.xml +++ b/app/src/main/res/values/strings_sy.xml @@ -172,8 +172,6 @@ AMOLED blue Black-Red - Midnight Dusk - Hot Pink Expand all search filters by default Automatically solve captcha Use HIGHLY EXPERIMENTAL automatic ReCAPTCHA solver. Will be grayed out if unsupported by your device. diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 5db5eb39a..bea4f4659 100755 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -6,23 +6,7 @@ - - - - - - - - @@ -30,6 +14,14 @@ ?attr/rippleToolbarColor + + + + @@ -80,6 +72,10 @@ @color/colorAccentDark + + @@ -393,18 +389,4 @@ - - - - - diff --git a/app/src/main/res/values/styles_sy.xml b/app/src/main/res/values/styles_sy.xml new file mode 100644 index 000000000..bee5a9454 --- /dev/null +++ b/app/src/main/res/values/styles_sy.xml @@ -0,0 +1,25 @@ + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml index b3f71e032..890bff4cf 100755 --- a/app/src/main/res/values/themes.xml +++ b/app/src/main/res/values/themes.xml @@ -4,16 +4,16 @@ - - - - + + + + + + + @@ -118,6 +135,8 @@ + + + - - - - - + + + + + + + + + + + + - - - - - - \ No newline at end of file