From 4e8c30b7fe2988211a37e8438d66ffa6bdae832d Mon Sep 17 00:00:00 2001 From: arkon Date: Mon, 7 Sep 2020 17:18:41 -0400 Subject: [PATCH] Start updating manga info view header design (SY edition) (cherry picked from commit 791a7d5a01e25b13634291fc1af5970ea35f7692) # Conflicts: # app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt # app/src/main/res/layout/manga_info_header.xml --- .../tachiyomi/ui/manga/MangaController.kt | 4 + .../chapter/MangaChaptersHeaderAdapter.kt | 2 +- .../ui/manga/info/MangaInfoHeaderAdapter.kt | 43 ++-- .../ui/manga/info/MangaInfoItemAdapter.kt | 17 +- .../main/res/color/outlined_button_stroke.xml | 4 - .../main/res/layout/manga_chapters_header.xml | 16 +- app/src/main/res/layout/manga_info_header.xml | 190 +++++++++--------- app/src/main/res/layout/manga_info_item.xml | 34 +--- app/src/main/res/menu/manga.xml | 5 + app/src/main/res/values/strings.xml | 2 +- app/src/main/res/values/strings_sy.xml | 1 + app/src/main/res/values/styles.xml | 33 +-- 12 files changed, 172 insertions(+), 179 deletions(-) delete mode 100644 app/src/main/res/color/outlined_button_stroke.xml diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaController.kt index f534e3c05..2cfa72a23 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaController.kt @@ -432,6 +432,7 @@ class MangaController : if (preferences.recommendsInOverflow().get()) menu.findItem(R.id.action_recommend).isVisible = true menu.findItem(R.id.action_merged).isVisible = presenter.manga.source == MERGED_SOURCE_ID menu.findItem(R.id.action_toggle_dedupe).isVisible = false // presenter.manga.source == MERGED_SOURCE_ID + menu.findItem(R.id.action_merge).isVisible = presenter.manga.favorite // SY <-- } @@ -465,6 +466,9 @@ class MangaController : presenter.dedupe = !presenter.dedupe presenter.toggleDedupe() } + R.id.action_merge -> { + openSmartSearch() + } // SY <-- R.id.action_edit_categories -> onCategoriesClick() diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/chapter/MangaChaptersHeaderAdapter.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/chapter/MangaChaptersHeaderAdapter.kt index 067b1e953..db09d9597 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/chapter/MangaChaptersHeaderAdapter.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/chapter/MangaChaptersHeaderAdapter.kt @@ -66,7 +66,7 @@ class MangaChaptersHeaderAdapter( } else { view.context.getResourceColor(R.attr.colorOnPrimary) } - DrawableCompat.setTint(binding.btnChaptersFilter.icon, filterColor) + DrawableCompat.setTint(binding.btnChaptersFilter.drawable, filterColor) merge(view.clicks(), binding.btnChaptersFilter.clicks()) .onEach { controller.showSettingsSheet() } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt index 472ac87ea..198621149 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoHeaderAdapter.kt @@ -115,13 +115,27 @@ class MangaInfoHeaderAdapter( isVisible = true if (trackCount > 0) { - setIconResource(R.drawable.ic_done_24dp) - text = view.context.resources.getQuantityString(R.plurals.num_trackers, trackCount, trackCount) - isChecked = true + setCompoundDrawablesWithIntrinsicBounds( + null, + ContextCompat.getDrawable(context, R.drawable.ic_done_24dp), + null, + null + ) + text = view.context.resources.getQuantityString( + R.plurals.num_trackers, + trackCount, + trackCount + ) + isSelected = true } else { - setIconResource(R.drawable.ic_sync_24dp) + setCompoundDrawablesWithIntrinsicBounds( + null, + ContextCompat.getDrawable(context, R.drawable.ic_sync_24dp), + null, + null + ) text = view.context.getString(R.string.manga_tracking_tab) - isChecked = false + isSelected = false } clicks() @@ -147,12 +161,6 @@ class MangaInfoHeaderAdapter( .onEach { controller.migrateManga() } .launchIn(scope) binding.btnMigrate.setTooltip(R.string.migrate) - - binding.btnSmartSearch.isVisible = true - binding.btnSmartSearch.clicks() - .onEach { controller.openSmartSearch() } - .launchIn(scope) - binding.btnSmartSearch.setTooltip(R.string.merge_with_another_source) } // SY <-- @@ -314,13 +322,18 @@ class MangaInfoHeaderAdapter( // Set the Favorite drawable to the correct one. // Border drawable if false, filled drawable if true. binding.btnFavorite.apply { - icon = ContextCompat.getDrawable( - context, - if (isFavorite) R.drawable.ic_favorite_24dp else R.drawable.ic_favorite_border_24dp + setCompoundDrawablesWithIntrinsicBounds( + null, + ContextCompat.getDrawable( + context, + if (isFavorite) R.drawable.ic_favorite_24dp else R.drawable.ic_favorite_border_24dp + ), + null, + null ) text = context.getString(if (isFavorite) R.string.in_library else R.string.add_to_library) - isChecked = isFavorite + isSelected = isFavorite } } } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoItemAdapter.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoItemAdapter.kt index 5944fbdf9..8d151cb30 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoItemAdapter.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoItemAdapter.kt @@ -114,7 +114,6 @@ class MangaInfoItemAdapter( if (binding.mangaSummaryText.text == "meta") { binding.mangaSummaryText.isVisible = false - binding.mangaSummaryLabel.setText(R.string.tags) } // Update genres list @@ -164,20 +163,22 @@ class MangaInfoItemAdapter( private fun toggleMangaInfo(context: Context) { val isExpanded = - binding.mangaInfoToggle.text == context.getString(R.string.manga_info_collapse) + binding.mangaInfoToggle.contentDescription == context.getString(R.string.manga_info_collapse) with(binding.mangaInfoToggle) { - text = if (isExpanded) { + contentDescription = if (isExpanded) { context.getString(R.string.manga_info_expand) } else { context.getString(R.string.manga_info_collapse) } - icon = if (isExpanded) { - context.getDrawable(R.drawable.ic_baseline_expand_more_24dp) - } else { - context.getDrawable(R.drawable.ic_baseline_expand_less_24dp) - } + setImageDrawable( + if (isExpanded) { + context.getDrawable(R.drawable.ic_baseline_expand_more_24dp) + } else { + context.getDrawable(R.drawable.ic_baseline_expand_less_24dp) + } + ) } with(binding.mangaSummaryText) { diff --git a/app/src/main/res/color/outlined_button_stroke.xml b/app/src/main/res/color/outlined_button_stroke.xml deleted file mode 100644 index 0702ae4c0..000000000 --- a/app/src/main/res/color/outlined_button_stroke.xml +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/app/src/main/res/layout/manga_chapters_header.xml b/app/src/main/res/layout/manga_chapters_header.xml index 8da2f17dd..5f580b13c 100644 --- a/app/src/main/res/layout/manga_chapters_header.xml +++ b/app/src/main/res/layout/manga_chapters_header.xml @@ -23,16 +23,16 @@ app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" /> - + app:layout_constraintTop_toTopOf="parent" + app:srcCompat="@drawable/ic_filter_list_24dp" + app:tint="?attr/colorOnPrimary" /> diff --git a/app/src/main/res/layout/manga_info_header.xml b/app/src/main/res/layout/manga_info_header.xml index 79a3e6948..7c8c82a30 100644 --- a/app/src/main/res/layout/manga_info_header.xml +++ b/app/src/main/res/layout/manga_info_header.xml @@ -15,6 +15,7 @@ android:id="@+id/backdrop" android:layout_width="0dp" android:layout_height="0dp" + android:layout_marginBottom="?attr/actionBarSize" android:alpha="0.2" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" @@ -25,6 +26,7 @@ @@ -33,7 +35,10 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="horizontal" - android:padding="16dp" + android:paddingStart="16dp" + android:paddingTop="64dp" + android:paddingEnd="16dp" + android:paddingBottom="16dp" app:layout_constraintTop_toTopOf="parent"> + android:layout_marginBottom="16dp" + android:orientation="vertical"> @@ -84,102 +88,108 @@ android:textIsSelectable="false" tools:text="Artist" /> - + android:layout_marginTop="4dp"> - + + + + + + + - + + + + + android:checkable="true" + android:text="@string/add_to_library" + app:drawableTopCompat="@drawable/ic_favorite_border_24dp" + app:layout_constraintEnd_toStartOf="@+id/btn_tracking" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toTopOf="parent" /> - + - + - - - - - - - - - - + diff --git a/app/src/main/res/layout/manga_info_item.xml b/app/src/main/res/layout/manga_info_item.xml index 431e1e761..76f572c3d 100644 --- a/app/src/main/res/layout/manga_info_item.xml +++ b/app/src/main/res/layout/manga_info_item.xml @@ -4,10 +4,11 @@ xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:tools="http://schemas.android.com/tools" - android:orientation="vertical" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?attr/selectableItemBackground"> + android:layout_marginTop="8dp" + android:background="?attr/selectableItemBackground" + android:orientation="vertical"> - - - + app:layout_constraintTop_toTopOf="parent" + app:srcCompat="@drawable/ic_baseline_expand_more_24dp" + app:tint="?attr/colorOnPrimary" /> diff --git a/app/src/main/res/menu/manga.xml b/app/src/main/res/menu/manga.xml index b9f906fcd..70806c965 100644 --- a/app/src/main/res/menu/manga.xml +++ b/app/src/main/res/menu/manga.xml @@ -52,6 +52,11 @@ android:title="@string/action_migrate" app:showAsAction="never" />--> + + Move Open in browser Open in WebView + WebView Open in Settings Migrate Display mode @@ -486,7 +487,6 @@ Title Added to library Removed from library - About More Less diff --git a/app/src/main/res/values/strings_sy.xml b/app/src/main/res/values/strings_sy.xml index 0b9bfafa4..af97a0b0d 100644 --- a/app/src/main/res/values/strings_sy.xml +++ b/app/src/main/res/values/strings_sy.xml @@ -554,6 +554,7 @@ Add to MangaDex follows MangaDex follows Random + Merge with another \ No newline at end of file diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 14738c01d..c6304f088 100755 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -100,15 +100,7 @@ - - - - - - -