From 26ed2865266b171be4776fd3a3f9b2b4d69d3da7 Mon Sep 17 00:00:00 2001
From: nicki <curche454@gmail.com>
Date: Fri, 23 Dec 2022 16:08:59 -0600
Subject: [PATCH] Refactor title selection logic (#14649)
most data in dex should be more stable than when this code was written
this is also how their Front-end does it
next refactor will be when the alt-title/title rework
---
.../tachiyomi/extension/all/mangadex/MangaDexHelper.kt | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/all/mangadex/src/eu/kanade/tachiyomi/extension/all/mangadex/MangaDexHelper.kt b/src/all/mangadex/src/eu/kanade/tachiyomi/extension/all/mangadex/MangaDexHelper.kt
index bde5cec80..ae9aaf503 100644
--- a/src/all/mangadex/src/eu/kanade/tachiyomi/extension/all/mangadex/MangaDexHelper.kt
+++ b/src/all/mangadex/src/eu/kanade/tachiyomi/extension/all/mangadex/MangaDexHelper.kt
@@ -264,14 +264,11 @@ class MangaDexHelper(lang: String) {
return SManga.create().apply {
url = "/manga/${mangaDataDto.id}"
val titleMap = mangaDataDto.attributes!!.title
- val dirtyTitle = titleMap[lang]
- ?: titleMap["en"]
- ?: titleMap["ja-ro"]
+ val dirtyTitle =
+ titleMap.values.firstOrNull() // use literally anything from title as first resort
?: mangaDataDto.attributes.altTitles
.find { (it[lang] ?: it["en"]) !== null }
- ?.values?.singleOrNull()
- ?: titleMap["ja"] // romaji titles are sometimes ja (and are not altTitles)
- ?: titleMap.values.firstOrNull() // use literally anything from title as a last resort
+ ?.values?.singleOrNull() // find something else from alt titles
title = cleanString(dirtyTitle ?: "")
coverFileName?.let {