From 252a1af799e3e1c2c4a4eb1d7a43a527e2ca05f3 Mon Sep 17 00:00:00 2001
From: DrMint <thomas@barillot.net>
Date: Fri, 11 Mar 2022 00:13:47 +0100
Subject: [PATCH] Replaced ternary operations with && when applicable

---
 src/components/AppLayout.tsx                  |   4 +-
 .../Chronology/ChronologyItemComponent.tsx    |   8 +-
 src/components/Content/ThumbnailHeader.tsx    |   8 +-
 src/components/Library/ContentTOCLine.tsx     |  12 +-
 .../Library/LibraryContentPreview.tsx         |   4 +-
 .../Library/LibraryItemsPreview.tsx           |  59 +++---
 .../PanelComponents/PanelHeader.tsx           |   4 +-
 src/components/Panels/MainPanel.tsx           |   8 +-
 src/pages/contents/[slug]/index.tsx           |  12 +-
 src/pages/contents/[slug]/read.tsx            |   8 +-
 src/pages/library/[slug].tsx                  | 170 +++++++-----------
 11 files changed, 107 insertions(+), 190 deletions(-)

diff --git a/src/components/AppLayout.tsx b/src/components/AppLayout.tsx
index a295b3f..51eab74 100644
--- a/src/components/AppLayout.tsx
+++ b/src/components/AppLayout.tsx
@@ -199,7 +199,7 @@ export default function AppLayout(props: AppLayoutProps): JSX.Element {
         </div>
 
         {/* Sub panel */}
-        {subPanel ? (
+        {subPanel && (
           <div
             className={`${subPanelClass} border-r-[1px] mobile:bottom-20 mobile:border-r-0 mobile:border-l-[1px] border-black border-dotted top-0 bottom-0 right-0 left-12 overflow-y-scroll webkit-scrollbar:w-0 [scrollbar-width:none] transition-transform duration-300 bg-light texture-paper-dots
           ${
@@ -212,8 +212,6 @@ export default function AppLayout(props: AppLayoutProps): JSX.Element {
           >
             {subPanel}
           </div>
-        ) : (
-          ""
         )}
 
         {/* Main panel */}
diff --git a/src/components/Chronology/ChronologyItemComponent.tsx b/src/components/Chronology/ChronologyItemComponent.tsx
index 090fb92..3864c27 100644
--- a/src/components/Chronology/ChronologyItemComponent.tsx
+++ b/src/components/Chronology/ChronologyItemComponent.tsx
@@ -64,15 +64,13 @@ export default function ChronologyItemComponent(
         props.item.attributes.day
       )}
     >
-      {props.displayYear ? (
+      {props.displayYear && (
         <p className="text-lg mt-[-.2em] font-bold">
           {generateYear(
             props.item.attributes.displayed_date,
             props.item.attributes.year
           )}
         </p>
-      ) : (
-        ""
       )}
 
       <p className="col-start-1 text-dark text-sm">
@@ -108,7 +106,7 @@ export default function ChronologyItemComponent(
                   {translation.title ? <h3>{translation.title}</h3> : ""}
                 </div>
 
-                {translation.description ? (
+                {translation.description && (
                   <p
                     className={
                       event.translations.length > 1
@@ -118,8 +116,6 @@ export default function ChronologyItemComponent(
                   >
                     {translation.description}
                   </p>
-                ) : (
-                  ""
                 )}
                 {translation.note ? (
                   <em>{"Notes: " + translation.note}</em>
diff --git a/src/components/Content/ThumbnailHeader.tsx b/src/components/Content/ThumbnailHeader.tsx
index 2b8ec2a..5ae6da6 100644
--- a/src/components/Content/ThumbnailHeader.tsx
+++ b/src/components/Content/ThumbnailHeader.tsx
@@ -53,7 +53,7 @@ export default function ThumbnailHeader(
       </div>
 
       <div className="grid grid-flow-col gap-8">
-        {content.type ? (
+        {content.type && (
           <div className="grid place-items-center place-content-start gap-2">
             <h3 className="text-xl">{langui.type}</h3>
             <Button>
@@ -62,19 +62,15 @@ export default function ThumbnailHeader(
                 : prettySlug(content.type.data.attributes.slug)}
             </Button>
           </div>
-        ) : (
-          ""
         )}
 
-        {content.categories.data.length > 0 ? (
+        {content.categories.data.length > 0 && (
           <div className="grid place-items-center place-content-start gap-2">
             <h3 className="text-xl">{langui.categories}</h3>
             {content.categories.data.map((category) => (
               <Button key={category.id}>{category.attributes.name}</Button>
             ))}
           </div>
-        ) : (
-          ""
         )}
       </div>
       {content.titles.length > 0 && content.titles[0].description && (
diff --git a/src/components/Library/ContentTOCLine.tsx b/src/components/Library/ContentTOCLine.tsx
index 9001184..4ac55e1 100644
--- a/src/components/Library/ContentTOCLine.tsx
+++ b/src/components/Library/ContentTOCLine.tsx
@@ -54,7 +54,7 @@ export default function ContentTOCLine(
             ? content.attributes.range[0].starting_page
             : ""}
         </p>
-        {content.attributes.content.data ? (
+        {content.attributes.content.data && (
           <Chip className="justify-self-end thin:hidden">
             {content.attributes.content.data.attributes.type.data.attributes
               .titles.length > 0
@@ -65,8 +65,6 @@ export default function ContentTOCLine(
                     .attributes.slug
                 )}
           </Chip>
-        ) : (
-          ""
         )}
       </div>
       <div
@@ -78,24 +76,20 @@ export default function ContentTOCLine(
           subdirectory_arrow_right
         </span>
 
-        {content.attributes.scan_set.length > 0 ? (
+        {content.attributes.scan_set.length > 0 && (
           <Button
             href={`/contents/${content.attributes.content.data.attributes.slug}/scans/`}
           >
             {langui.view_scans}
           </Button>
-        ) : (
-          ""
         )}
 
-        {content.attributes.content.data ? (
+        {content.attributes.content.data && (
           <Button
             href={`/contents/${content.attributes.content.data.attributes.slug}`}
           >
             {langui.open_content}
           </Button>
-        ) : (
-          ""
         )}
 
         {content.attributes.scan_set.length === 0 &&
diff --git a/src/components/Library/LibraryContentPreview.tsx b/src/components/Library/LibraryContentPreview.tsx
index bcebbce..8017528 100644
--- a/src/components/Library/LibraryContentPreview.tsx
+++ b/src/components/Library/LibraryContentPreview.tsx
@@ -33,14 +33,12 @@ export default function LibraryContentPreview(
         )}
         <div className="linearbg-obi fine:drop-shadow-shade-lg fine:absolute coarse:rounded-b-md bottom-2 -inset-x-0.5 opacity-[var(--cover-opacity)] transition-opacity z-20 grid p-4 gap-2">
           <div className="grid grid-flow-col gap-1 overflow-hidden place-content-start">
-            {item.type.data ? (
+            {item.type.data && (
               <Chip>
                 {item.type.data.attributes.titles.length > 0
                   ? item.type.data.attributes.titles[0].title
                   : prettySlug(item.type.data.attributes.slug)}
               </Chip>
-            ) : (
-              ""
             )}
           </div>
           <div>
diff --git a/src/components/Library/LibraryItemsPreview.tsx b/src/components/Library/LibraryItemsPreview.tsx
index a8cc035..392a3fc 100644
--- a/src/components/Library/LibraryItemsPreview.tsx
+++ b/src/components/Library/LibraryItemsPreview.tsx
@@ -44,12 +44,10 @@ export default function LibraryItemsPreview(
         )}
 
         <div className="linearbg-obi fine:drop-shadow-shade-lg fine:absolute place-items-start bottom-2 -inset-x-0.5 opacity-[var(--cover-opacity)] transition-opacity z-20 grid p-4 gap-2">
-          {item.metadata && item.metadata.length > 0 ? (
+          {item.metadata && item.metadata.length > 0 && (
             <div className="flex flex-row gap-1">
               <Chip>{prettyItemSubType(item.metadata[0])}</Chip>
             </div>
-          ) : (
-            ""
           )}
 
           <div>
@@ -65,36 +63,31 @@ export default function LibraryItemsPreview(
             ))}
           </div>
 
-          {item.release_date || item.price ? (
-            <div className="grid grid-flow-col w-full">
-              {item.release_date ? (
-                <p className="mobile:text-xs text-sm">
-                  <span className="material-icons !text-base translate-y-[.15em] mr-1">
-                    event
-                  </span>
-                  {prettyDate(item.release_date)}
-                </p>
-              ) : (
-                ""
-              )}
-              {item.price && props.currencies ? (
-                <p className="mobile:text-xs text-sm justify-self-end">
-                  <span className="material-icons !text-base translate-y-[.15em] mr-1">
-                    shopping_cart
-                  </span>
-                  {prettyPrice(
-                    item.price,
-                    props.currencies,
-                    appLayout.currency
-                  )}
-                </p>
-              ) : (
-                ""
-              )}
-            </div>
-          ) : (
-            ""
-          )}
+          {item.release_date ||
+            (item.price && (
+              <div className="grid grid-flow-col w-full">
+                {item.release_date && (
+                  <p className="mobile:text-xs text-sm">
+                    <span className="material-icons !text-base translate-y-[.15em] mr-1">
+                      event
+                    </span>
+                    {prettyDate(item.release_date)}
+                  </p>
+                )}
+                {item.price && props.currencies && (
+                  <p className="mobile:text-xs text-sm justify-self-end">
+                    <span className="material-icons !text-base translate-y-[.15em] mr-1">
+                      shopping_cart
+                    </span>
+                    {prettyPrice(
+                      item.price,
+                      props.currencies,
+                      appLayout.currency
+                    )}
+                  </p>
+                )}
+              </div>
+            ))}
         </div>
       </div>
     </Link>
diff --git a/src/components/PanelComponents/PanelHeader.tsx b/src/components/PanelComponents/PanelHeader.tsx
index 94e32b3..925d46d 100644
--- a/src/components/PanelComponents/PanelHeader.tsx
+++ b/src/components/PanelComponents/PanelHeader.tsx
@@ -10,10 +10,8 @@ export default function PanelHeader(props: PanelHeaderProps): JSX.Element {
   return (
     <>
       <div className="w-full grid place-items-center">
-        {props.icon ? (
+        {props.icon && (
           <span className="material-icons !text-4xl mb-3">{props.icon}</span>
-        ) : (
-          ""
         )}
         <h2 className="text-2xl">{props.title}</h2>
         {props.description ? <p>{props.description}</p> : ""}
diff --git a/src/components/Panels/MainPanel.tsx b/src/components/Panels/MainPanel.tsx
index 0390ccf..f1928fa 100644
--- a/src/components/Panels/MainPanel.tsx
+++ b/src/components/Panels/MainPanel.tsx
@@ -192,10 +192,8 @@ export default function MainPanel(props: MainPanelProps): JSX.Element {
         }`}
       >
         <p>
-          {langui.licensing_notice ? (
+          {langui.licensing_notice && (
             <Markdown>{langui.licensing_notice}</Markdown>
-          ) : (
-            ""
           )}
         </p>
         <a
@@ -210,10 +208,8 @@ export default function MainPanel(props: MainPanelProps): JSX.Element {
           </div>
         </a>
         <p>
-          {langui.copyright_notice ? (
+          {langui.copyright_notice && (
             <Markdown>{langui.copyright_notice}</Markdown>
-          ) : (
-            ""
           )}
         </p>
         <div className="mt-12 mb-4 grid h-4 grid-flow-col place-content-center gap-8">
diff --git a/src/pages/contents/[slug]/index.tsx b/src/pages/contents/[slug]/index.tsx
index 1c9726d..e3799bb 100644
--- a/src/pages/contents/[slug]/index.tsx
+++ b/src/pages/contents/[slug]/index.tsx
@@ -44,28 +44,22 @@ export default function ContentIndex(props: ContentIndexProps): JSX.Element {
 
         <HorizontalLine />
 
-        {content.text_set.length > 0 ? (
+        {content.text_set.length > 0 && (
           <Button href={`/contents/${content.slug}/read/`}>
             {langui.read_content}
           </Button>
-        ) : (
-          ""
         )}
 
-        {content.audio_set.length > 0 ? (
+        {content.audio_set.length > 0 && (
           <Button href={`/contents/${content.slug}/listen/`}>
             {langui.listen_content}
           </Button>
-        ) : (
-          ""
         )}
 
-        {content.video_set.length > 0 ? (
+        {content.video_set.length > 0 && (
           <Button href={`/contents/${content.slug}/watch/`}>
             {langui.watch_content}
           </Button>
-        ) : (
-          ""
         )}
       </div>
     </ContentPanel>
diff --git a/src/pages/contents/[slug]/read.tsx b/src/pages/contents/[slug]/read.tsx
index 8dc58cb..8a6fc0b 100644
--- a/src/pages/contents/[slug]/read.tsx
+++ b/src/pages/contents/[slug]/read.tsx
@@ -47,7 +47,7 @@ export default function ContentRead(props: ContentReadProps): JSX.Element {
         horizontalLine
       />
 
-      {content.text_set.length > 0 ? (
+      {content.text_set.length > 0 && (
         <div className="grid gap-5">
           <h2 className="text-xl">
             {content.text_set[0].source_language.data.attributes.code ===
@@ -140,8 +140,6 @@ export default function ContentRead(props: ContentReadProps): JSX.Element {
             </div>
           )}
         </div>
-      ) : (
-        ""
       )}
     </SubPanel>
   );
@@ -159,10 +157,8 @@ export default function ContentRead(props: ContentReadProps): JSX.Element {
 
         <HorizontalLine />
 
-        {content.text_set.length > 0 ? (
+        {content.text_set.length > 0 && (
           <Markdawn text={content.text_set[0].text} />
-        ) : (
-          ""
         )}
       </div>
     </ContentPanel>
diff --git a/src/pages/library/[slug].tsx b/src/pages/library/[slug].tsx
index 7df9fca..f4fdba3 100644
--- a/src/pages/library/[slug].tsx
+++ b/src/pages/library/[slug].tsx
@@ -70,15 +70,13 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
           onClick={() => appLayout.setSubPanelOpen(false)}
         />
 
-        {item.gallery.data.length > 0 ? (
+        {item.gallery.data.length > 0 && (
           <NavOption
             title={langui.gallery}
             url="#gallery"
             border
             onClick={() => appLayout.setSubPanelOpen(false)}
           />
-        ) : (
-          ""
         )}
 
         <NavOption
@@ -88,21 +86,17 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
           onClick={() => appLayout.setSubPanelOpen(false)}
         />
 
-        {item.subitems.data.length > 0 ? (
+        {item.subitems.data.length > 0 && (
           <NavOption
             title={isVariantSet ? langui.variants : langui.subitems}
             url={isVariantSet ? "#variants" : "#subitems"}
             border
             onClick={() => appLayout.setSubPanelOpen(false)}
           />
-        ) : (
-          ""
         )}
 
-        {item.contents.data.length > 0 ? (
+        {item.contents.data.length > 0 && (
           <NavOption title={langui.contents} url="#contents" border />
-        ) : (
-          ""
         )}
       </div>
     </SubPanel>
@@ -134,7 +128,7 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
 
         <InsetBox id="summary" className="grid place-items-center">
           <div className="w-[clamp(0px,100%,42rem)] grid place-items-center gap-8">
-            {item.subitem_of.data.length > 0 ? (
+            {item.subitem_of.data.length > 0 && (
               <div className="grid place-items-center">
                 <p>{langui.subitem_of}</p>
                 <Button
@@ -147,26 +141,18 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
                   )}
                 </Button>
               </div>
-            ) : (
-              ""
             )}
             <div className="grid place-items-center">
               <h1 className="text-3xl">{item.title}</h1>
-              {item.subtitle ? (
-                <h2 className="text-2xl">{item.subtitle}</h2>
-              ) : (
-                ""
-              )}
+              {item.subtitle && <h2 className="text-2xl">{item.subtitle}</h2>}
             </div>
-            {item.descriptions.length > 0 ? (
+            {item.descriptions.length > 0 && (
               <p className="text-justify">{item.descriptions[0].description}</p>
-            ) : (
-              ""
             )}
           </div>
         </InsetBox>
 
-        {item.gallery.data.length > 0 ? (
+        {item.gallery.data.length > 0 && (
           <div id="gallery" className="grid place-items-center gap-8  w-full">
             <h2 className="text-2xl">{langui.gallery}</h2>
             <div className="grid w-full gap-8 items-end grid-cols-[repeat(auto-fill,_minmax(15rem,1fr))]">
@@ -186,15 +172,13 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
               ))}
             </div>
           </div>
-        ) : (
-          ""
         )}
 
         <InsetBox id="details" className="grid place-items-center">
           <div className="w-[clamp(0px,100%,42rem)] grid place-items gap-8">
             <h2 className="text-2xl text-center">{langui.details}</h2>
             <div className="grid grid-flow-col w-full place-content-between">
-              {item.metadata.length > 0 ? (
+              {item.metadata.length > 0 && (
                 <div className="grid place-items-center place-content-start">
                   <h3 className="text-xl">{langui.type}</h3>
                   <div className="grid grid-flow-col gap-1">
@@ -203,20 +187,16 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
                     <Chip>{prettyItemSubType(item.metadata[0])}</Chip>
                   </div>
                 </div>
-              ) : (
-                ""
               )}
 
-              {item.release_date ? (
+              {item.release_date && (
                 <div className="grid place-items-center place-content-start">
                   <h3 className="text-xl">{langui.release_date}</h3>
                   <p>{prettyDate(item.release_date)}</p>
                 </div>
-              ) : (
-                ""
               )}
 
-              {item.price ? (
+              {item.price && (
                 <div className="grid place-items-center text-center place-content-start">
                   <h3 className="text-xl">{langui.price}</h3>
                   <p>
@@ -234,11 +214,9 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
                     </p>
                   )}
                 </div>
-              ) : (
-                ""
               )}
             </div>
-            {item.size ? (
+            {item.size && (
               <>
                 <h3 className="text-xl">{langui.size}</h3>
                 <div className="grid grid-flow-col w-full place-content-between">
@@ -256,7 +234,7 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
                       <p>{convertMmToInch(item.size.height)} in</p>
                     </div>
                   </div>
-                  {item.size.thickness ? (
+                  {item.size.thickness && (
                     <div className="flex flex-row flex-wrap place-items-start gap-4">
                       <p className="font-bold">{langui.thickness}:</p>
                       <div>
@@ -264,84 +242,68 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
                         <p>{convertMmToInch(item.size.thickness)} in</p>
                       </div>
                     </div>
-                  ) : (
-                    ""
                   )}
                 </div>
               </>
-            ) : (
-              ""
             )}
 
             {item.metadata.length > 0 &&
-            item.metadata[0].__typename !== "ComponentMetadataGroup" &&
-            item.metadata[0].__typename !== "ComponentMetadataOther" ? (
-              <>
-                <h3 className="text-xl">{langui.type_information}</h3>
-                <div className="grid grid-cols-2 w-full place-content-between">
-                  {item.metadata[0].__typename === "ComponentMetadataBooks" ? (
-                    <>
-                      <div className="flex flex-row place-content-start gap-4">
-                        <p className="font-bold">{langui.pages}:</p>
-                        <p>{item.metadata[0].page_count}</p>
-                      </div>
+              item.metadata[0].__typename !== "ComponentMetadataGroup" &&
+              item.metadata[0].__typename !== "ComponentMetadataOther" && (
+                <>
+                  <h3 className="text-xl">{langui.type_information}</h3>
+                  <div className="grid grid-cols-2 w-full place-content-between">
+                    {item.metadata[0].__typename ===
+                      "ComponentMetadataBooks" && (
+                      <>
+                        <div className="flex flex-row place-content-start gap-4">
+                          <p className="font-bold">{langui.pages}:</p>
+                          <p>{item.metadata[0].page_count}</p>
+                        </div>
 
-                      <div className="flex flex-row place-content-start gap-4">
-                        <p className="font-bold">{langui.binding}:</p>
-                        <p>
-                          {item.metadata[0].binding_type ===
-                          Enum_Componentmetadatabooks_Binding_Type.Paperback
-                            ? langui.paperback
-                            : item.metadata[0].binding_type ===
-                              Enum_Componentmetadatabooks_Binding_Type.Hardcover
-                            ? langui.hardcover
-                            : ""}
-                        </p>
-                      </div>
-
-                      <div className="flex flex-row place-content-start gap-4">
-                        <p className="font-bold">{langui.page_order}:</p>
-                        <p>
-                          {item.metadata[0].page_order ===
-                          Enum_Componentmetadatabooks_Page_Order.LeftToRight
-                            ? langui.left_to_right
-                            : item.metadata[0].page_order ===
-                              Enum_Componentmetadatabooks_Page_Order.RightToLeft
-                            ? langui.right_to_left
-                            : ""}
-                        </p>
-                      </div>
-
-                      <div className="flex flex-row place-content-start gap-4">
-                        <p className="font-bold">{langui.languages}:</p>
-                        {item.metadata[0].languages.data.map((lang) => (
-                          <p key={lang.attributes.code}>
-                            {lang.attributes.name}
+                        <div className="flex flex-row place-content-start gap-4">
+                          <p className="font-bold">{langui.binding}:</p>
+                          <p>
+                            {item.metadata[0].binding_type ===
+                            Enum_Componentmetadatabooks_Binding_Type.Paperback
+                              ? langui.paperback
+                              : item.metadata[0].binding_type ===
+                                Enum_Componentmetadatabooks_Binding_Type.Hardcover
+                              ? langui.hardcover
+                              : ""}
                           </p>
-                        ))}
-                      </div>
-                    </>
-                  ) : item.metadata[0].__typename ===
-                    "ComponentMetadataAudio" ? (
-                    <></>
-                  ) : item.metadata[0].__typename ===
-                    "ComponentMetadataVideo" ? (
-                    <></>
-                  ) : item.metadata[0].__typename ===
-                    "ComponentMetadataGame" ? (
-                    <></>
-                  ) : (
-                    ""
-                  )}
-                </div>
-              </>
-            ) : (
-              ""
-            )}
+                        </div>
+
+                        <div className="flex flex-row place-content-start gap-4">
+                          <p className="font-bold">{langui.page_order}:</p>
+                          <p>
+                            {item.metadata[0].page_order ===
+                            Enum_Componentmetadatabooks_Page_Order.LeftToRight
+                              ? langui.left_to_right
+                              : item.metadata[0].page_order ===
+                                Enum_Componentmetadatabooks_Page_Order.RightToLeft
+                              ? langui.right_to_left
+                              : ""}
+                          </p>
+                        </div>
+
+                        <div className="flex flex-row place-content-start gap-4">
+                          <p className="font-bold">{langui.languages}:</p>
+                          {item.metadata[0].languages.data.map((lang) => (
+                            <p key={lang.attributes.code}>
+                              {lang.attributes.name}
+                            </p>
+                          ))}
+                        </div>
+                      </>
+                    )}
+                  </div>
+                </>
+              )}
           </div>
         </InsetBox>
 
-        {item.subitems.data.length > 0 ? (
+        {item.subitems.data.length > 0 && (
           <div
             id={isVariantSet ? "variants" : "subitems"}
             className="grid place-items-center gap-8 w-full"
@@ -358,11 +320,9 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
               ))}
             </div>
           </div>
-        ) : (
-          ""
         )}
 
-        {item.contents.data.length > 0 ? (
+        {item.contents.data.length > 0 && (
           <div id="contents" className="w-full grid place-items-center gap-8">
             <h2 className="text-2xl">{langui.contents}</h2>
             <div className="grid gap-4 w-full">
@@ -376,8 +336,6 @@ export default function LibrarySlug(props: LibrarySlugProps): JSX.Element {
               ))}
             </div>
           </div>
-        ) : (
-          ""
         )}
       </div>
     </ContentPanel>